streamingccl, rowexec: correctly mark eventStream as "streaming"#85866
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 10, 2022
Merged
streamingccl, rowexec: correctly mark eventStream as "streaming"#85866craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
This commit fixes an incomplete solution of 9bb5d30 which attempted to mark `eventStream` generator builtin as "streaming" so that the columnarizer on top of the `projectSetProcessor` would not buffer anything. As found by Steven, the solution in that commit was incomplete since the generators array is not populated at the time where `MustBeStreaming` check is performed. This commit fixes that oversight by using a different way of propagating the property - via the function properties. Release note: None
09a718f to
9b8100b
Compare
stevendanna
approved these changes
Aug 10, 2022
Member
Author
|
TFTR! bors r+ |
Contributor
|
This PR was included in a batch that was canceled, it will be automatically retried |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This was referenced Sep 7, 2022
craig bot
pushed a commit
that referenced
this pull request
Nov 18, 2022
87532: streamingest: unskip TestTenantStreamingDeleteRange r=stevendanna a=adityamaru #85866 seems to have stabilized this test, 5+ mins of stressing led to no failures so it seems safe to unskip. Release note: None Release justification: low risk, test only change Fixes: #85630 Co-authored-by: adityamaru <adityamaru@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an incomplete solution of
9bb5d30 which attempted to mark
eventStreamgenerator builtin as "streaming" so that the columnarizeron top of the
projectSetProcessorwould not buffer anything. As foundby Steven, the solution in that commit was incomplete since the
generators array is not populated at the time where
MustBeStreamingcheck is performed. This commit fixes that oversight by using
a different way of propagating the property - via the function
properties.
Release note: None