streamingccl: multi-node unit tests#85735
Conversation
|
This change is |
7c86185 to
4e170b7
Compare
None of our tests used to run with multiple nodes and a scattered table, so this PR re-enables the unvavailable node test and creates a new basic multinode test. Release note: None
4e170b7 to
e39d25b
Compare
gh-casper
left a comment
There was a problem hiding this comment.
I remember we had the ingestion job cutover bug in multiple nodes mode. Is this PR to fix that? It'll be better to update the description to briefly describe where the bug is and how it's fixed?
|
@gh-casper The issue didn't end up happening anymore, at least not like it used to, so I think it was somehow fixed by one of the PRs that were in flight at the time. The only bug fix here was around the creation statement being retried, added that to the description now 👍 It's likely that #85866 was the issue I was seeing during the roachprod demo. |
gh-casper
left a comment
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @samiskin)
|
bors r+ |
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
None of our tests used to run with multiple nodes and a scattered table,
so this PR re-enables the unavailable node test and creates a new basic
multinode test.
It also fixes a bug where if the stream creation statement was retried, it
would now error on an existing tenant, since the tenant creation wasn't
associated with the overall transaction.
Release note: None