sql,logictest,descidgen: abstract descriptor ID generation, make deterministic in logictests#85366
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Aug 1, 2022
Conversation
Member
|
This change is |
postamar
approved these changes
Aug 1, 2022
postamar
left a comment
There was a problem hiding this comment.
LGTM assuming the test failure in CI is unrelated or easily addressed. This is a Good Change.
This adds a layer of indirection around descriptor ID generation in order to facilitate injecting transactional generation. Release note: None
This commit adds a testing knob which results in descriptor ID generation being handled transactionally. The logictests now use this knob. Fixes cockroachdb#37751 Fixes cockroachdb#69226 Release note: None
76125a3 to
85ce24d
Compare
Contributor
Author
|
I'm pretty certain that this change is not causing any of the failures. They seem to be under stressrace. This change forces lots of those to run, and they seem flakey. This change doesn't affect any of those tests, so I don't think it's related. TFTR! bors r+ |
Contributor
|
Build succeeded: |
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this pull request
Aug 2, 2022
In cockroachdb#85366, we introduced a mechanism to make descriptor ID generation transactional and, in the absence of parallelism, deterministic. That PR failed to set the knob for secondary tenant configurations. This commit rectifies that oversight. This should allow us to avoid flakes like: https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_GitHubCiOptional/5939930?showRootCauses=false&expandBuildChangesSection=true&expandBuildProblemsSection=true&expandBuildTestsSection=true Release note: None
craig bot
pushed a commit
that referenced
this pull request
Aug 2, 2022
85444: logictest: use deterministic ID generation in tenants r=ajwerner a=ajwerner In #85366, we introduced a mechanism to make descriptor ID generation transactional and, in the absence of parallelism, deterministic. That PR failed to set the knob for secondary tenant configurations. This commit rectifies that oversight. This should allow us to avoid flakes like: https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_GitHubCiOptional/5939930?showRootCauses=false&expandBuildChangesSection=true&expandBuildProblemsSection=true&expandBuildTestsSection=true Release note: None Co-authored-by: Andrew Werner <awerner32@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit adds an interface for descriptor ID generation and propagates the interface from the ExecCfg into the EvalContext. There are some minor refactoring to avoid propagating an ExecCfg further up the stack by making the parameters more specific. The second commit adds a testing knob to use a transactional implementation in the EvalContext.
Fixes #37751
Fixes #69226