eval: stop ignoring all ResolveOIDFromOID errors#85086
eval: stop ignoring all ResolveOIDFromOID errors#85086craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
The decision about whether an error is safe to ignore is made at the place where the error is created/returned. This way, the callers don't need to be aware of any new error codes that the implementation may start returning in the future. Release note (bug fix): Fixed incorrect error handling that could cause casts to OID types to fail in some cases.
6956a2b to
6817eb6
Compare
|
tftr! bors r=ajwerner |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 6817eb6 to blathers/backport-release-21.2-85086: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 21.2.x failed. See errors above. error creating merge commit from 6817eb6 to blathers/backport-release-22.1-85086: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
fixes #84448
The decision about whether an error is safe to ignore is made at the
place where the error is created/returned. This way, the callers don't
need to be aware of any new error codes that the implementation may
start returning in the future.
Release note (bug fix): Fixed incorrect error handling that could cause
casts to OID types to fail in some cases.