Skip to content

sql: errors from ResolveOIDFromOID are ignored #84448

@fqazi

Description

@fqazi

When we hit transaction retry errors the following code paths can end up swallowing errors, which can lead to other issues:

if err != nil {

dOid, err := res.ResolveOIDFromOID(ctx, t, tree.NewDOid(o))

We ran into this scenario in the randomized schema changer workload where OID casts combined with transaction retry errors could lead to failures.

Jira issue: CRDB-17664
Epic CRDB-14049

Metadata

Metadata

Assignees

Labels

C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-sql-foundationsSQL Foundations Team (formerly SQL Schema + SQL Sessions)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions