-
Notifications
You must be signed in to change notification settings - Fork 4.1k
sql: errors from ResolveOIDFromOID are ignored #84448
Copy link
Copy link
Closed
Labels
C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-sql-foundationsSQL Foundations Team (formerly SQL Schema + SQL Sessions)SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Description
When we hit transaction retry errors the following code paths can end up swallowing errors, which can lead to other issues:
cockroach/pkg/sql/sem/eval/cast.go
Line 959 in cc5bde5
| if err != nil { |
cockroach/pkg/sql/sem/eval/cast.go
Line 958 in cc5bde5
| dOid, err := res.ResolveOIDFromOID(ctx, t, tree.NewDOid(o)) |
We ran into this scenario in the randomized schema changer workload where OID casts combined with transaction retry errors could lead to failures.
Jira issue: CRDB-17664
Epic CRDB-14049
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-sql-foundationsSQL Foundations Team (formerly SQL Schema + SQL Sessions)SQL Foundations Team (formerly SQL Schema + SQL Sessions)