insights: crdb_internal.cluster_execution_insights#84998
Closed
matthewtodd wants to merge 1 commit intocockroachdb:masterfrom
matthewtodd:cluster-execution-insights
Closed
insights: crdb_internal.cluster_execution_insights#84998matthewtodd wants to merge 1 commit intocockroachdb:masterfrom matthewtodd:cluster-execution-insights
matthewtodd wants to merge 1 commit intocockroachdb:masterfrom
matthewtodd:cluster-execution-insights
Conversation
Member
|
This change is |
Here we introduce a new virtual table for a cluster-wide view of "insights," a subsystem of sqlstats that is currently disabled by default but that will identify slow- and slower-than-usual statement executions, along with other potentially problematic behaviors we will be building support for. This table will back the upcoming insights UI over the new SQL-over-HTTP endpoint. Release note (sql change): A new crdb_internal virtual table, cluster_execution_insights, was introduced, offering a cluster-wide view of the same node-local information available in node_execution_insights. The insights subsystem is, as of this commit, still under development and disabled by default, so there will not yet be much to see here.
craig bot
pushed a commit
that referenced
this pull request
Aug 12, 2022
84612: ui: add insights overview page v1 r=maryliag a=ericharmeling This commit adds the v1 Insights page to the DB Console, via the cluster-ui package. The v1 Insights page only includes a Transactions Insights overview page, populated with information served a new "endpoint" built on top of the SQL-over-HTTP API. Note this PR is dependent on the changes in #84617 and #85080. After #84998 is merged with all the needed columns, we can rewrite the insights API to query the internal insights table. Fixes #83774. Release note (ui change): Added new Insights page to DB Console 85757: backupccl,importer: remove `at_current_time` cluster settings r=adityamaru a=erikgrinaker Release note (ops change): The cluster settings `bulkio.restore_at_current_time.enabled` and `bulkio.import_at_current_time.enabled`, which were introduced in 22.1 and defaulted to `true`, have been retired. They are now in effect always enabled. Co-authored-by: Eric Harmeling <eric.harmeling@cockroachlabs.com> Co-authored-by: Erik Grinaker <grinaker@cockroachlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here we introduce a new virtual table for a cluster-wide view of
"insights," a subsystem of sqlstats that is currently disabled by
default but that will identify slow- and slower-than-usual statement
executions, along with other potentially problematic behaviors we will
be building support for.
This table will back the upcoming insights UI over the new SQL-over-HTTP
endpoint.
Release note (sql change): A new
crdb_internalvirtual table,cluster_execution_insights, was introduced, offering a cluster-wide viewof the same node-local information available in
node_execution_insights.The insights subsystem is, as of this commit, still under development
and disabled by default, so there will not yet be much to see here.