Skip to content

release-22.1: ui: make Metrics and SQL timepicker align#83507

Merged
maryliag merged 1 commit intocockroachdb:release-22.1from
maryliag:backport22.1-83107
Jun 28, 2022
Merged

release-22.1: ui: make Metrics and SQL timepicker align#83507
maryliag merged 1 commit intocockroachdb:release-22.1from
maryliag:backport22.1-83107

Conversation

@maryliag
Copy link
Copy Markdown
Contributor

@maryliag maryliag commented Jun 28, 2022

Backport 1/1 commits from #83107

/cc @cockroachdb/release

Previously, the timepicker from Metrics page and
the timepicker on SQL Activity pages acted independently.
Now, if the value of one changes, the other value changes
to the same period selected.

This commit also fixes a bug where the period selected
would change to a custom value if the Metrics page was
refreshed.

Fixes #78187
Fixes #82152

Release note (ui change): The period selected on the Metrics
page and the SQL Activity pages are now aligned. If the user
changes in one page, the value will be the same for the other.

Release note (bug fix): The period selected on Metrics time picker
continues the same when refreshing the page, no longer changing
to a custom period.

Release justification: high impact change

@maryliag
ui: make Metrics and SQL timepicker align
f903328 
Previously, the timepicker from Metrics page and
the timepicker on SQL Activity pages acted independently.
Now, if the value of one changes, the other value changes
to the same period selected.

This commit also fixes a bug where the period selected
would change to a custom value if the Metrics page was
refreshed.

Fixes cockroachdb#78187
Fixes cockroachdb#82152

Release note (ui change): The period selected on the Metrics
page and the SQL Activity pages are now aligned. If the user
changes in one page, the value will be the same for the other.

Release note (bug fix): The period selected on Metrics time picker
continues the same when refreshing the page, no longer changing
to a custom period.
@maryliag maryliag requested a review from a team June 28, 2022 13:45
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Jun 28, 2022 •
edited by maryliag
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Jun 28, 2022

This change is Reviewable

xinhaoz
xinhaoz approved these changes Jun 28, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@xinhaoz xinhaoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 11 of 17 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @xinhaoz)

@maryliag maryliag merged commit 98b0556 into cockroachdb:release-22.1 Jun 28, 2022
@maryliag maryliag deleted the backport22.1-83107 branch June 28, 2022 20:51
@jlinder jlinder mentioned this pull request Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@xinhaoz xinhaoz xinhaoz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maryliag @cockroach-teamcity @xinhaoz