-
Notifications
You must be signed in to change notification settings - Fork 4.1k
ui: prevent default time scale option from changing to custom time scale option on Metrics page refresh #82152
Description
On refreshing the Metrics page of the DB Console, default time scales become custom time scales. After recent UX improvements, this behavior can result in the custom time scale dropdown menu appearing for default time scales, which can be confusing to users.
@irfansharif caught bug 5/30/2022: https://www.loom.com/share/d51756814b764002b0956ff8264f2645
Reproduced 5/31/2022 on v22.1.0-alpha.00000000-5234-g48d7fe3782:
Screen.Recording.2022-05-31.at.11.26.39.AM.mov
The bug appears to have existed for a while now, as this behavior is also present in older versions (e.g., 21.1.18):
Screen.Recording.2022-05-31.at.11.19.26.AM.mov
As seen in the repro videos, selecting a preset time interval on the Metrics page adds start and end parameters to the URL, which appears to change the default time scale to a custom time scale on refresh. Other pages that use the TimeScaleDropdown component (e.g., the SQL Activity page) do not update the URL or change the default time scales to custom time scales, so we should probably look at those pages when resolving the issue.
Jira issue: CRDB-16227