storage: specify and test iterator visibility semantics#81279
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 25, 2022
Merged
storage: specify and test iterator visibility semantics#81279craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
bd229b5 to
ec1cdf2
Compare
2b0c23a to
d01c884
Compare
jbowens
approved these changes
May 19, 2022
Contributor
jbowens
left a comment
There was a problem hiding this comment.
Hoping to get #81389 merged today, so we can unblock the bump that includes the new semantics.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @nicktrav and @sumeerbhola)
This patch specifies and tests iterator visibility semantics. See comment on `Engine.NewMVCCIterator` for details. Release note: None
d01c884 to
a779072
Compare
Contributor
Author
|
bors r=jbowens |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jbowens I split this out from the range key PR in #77417, since we'll need to audit/update existing code for the new point key batch semantics, and it seems cleaner/easier to do this separately. As you know, the test currently fails because existing batch iterators see concurrent batch writes.
This only covers point keys, but range keys should have identical semantics, and the tests will be extended for range keys in #77417.
This patch specifies and tests iterator visibility semantics. See
comment on
Engine.NewMVCCIteratorfor details.Release note: None