vendor: bump Pebble to e567fec84c6e#81389
Conversation
|
This change is |
07cfcd6 to
685e9ce
Compare
nicktrav
left a comment
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @jbowens)
There was a problem hiding this comment.
Still wrangling with two issues:
kv/kvserver.TestStoreMetricsis showing reduced bloom filter lookups.sql/colexec.TestExternalDistincthas a goroutine leak from the disk-health checking. It appears to be file-level goroutines (not the new filesystem-wide goroutine) that are leaking, but it's a new leak with this commit. Still digging.
Reviewable status:
685e9ce to
e38c096
Compare
e38c096 to
047685b
Compare
nicktrav
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status:
047685b to
9743844
Compare
nicktrav
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status:
9743844 to
804ed95
Compare
804ed95 to
77acc3f
Compare
|
|
77acc3f to
52d1182
Compare
52d1182 to
ad606d0
Compare
nicktrav
left a comment
There was a problem hiding this comment.
Thanks for persevering with this yak shave!
Reviewed 9 of 13 files at r7, 10 of 10 files at r8, all commit messages.
Reviewable status:
|
I think I found the other problem - #81490 and will open a fix shortly. |
0f23bec to
aec0ab0
Compare
nicktrav
left a comment
There was a problem hiding this comment.
Reviewed 9 of 9 files at r9, all commit messages.
Reviewable status:
aec0ab0 to
76b37d0
Compare
|
Hrm, recent pushes aren't tickling CI |
76b37d0 to
1c696b8
Compare
|
Isn't the |
c62e455 to
31fa14c
Compare
|
Yes, it was a bad rebase for poking CI. This doesn't need any review until there's a green CI. |
This commit includes non-trivial changes to account for the change in the `vfs.WithDiskHealthChecks` function signature change. ``` e567fec8 db: ensure Open closes opened directories on error b8c9a560 internal/metamorphic: overwrite unused bounds buffers 7c5f0cbb db: copy user-provided bounds and optimize unchanged bounds f8897076 *: Add IterOption to optionally read L6 filter blocks. d79f9617 vfs: extend disk-health checking to filesystem metadata operations 5ae21746 db: remove newRangeKeyIter closure 6d975489 db: add BenchmarkIteratorScan 782d102e sstable: fix invariant check for sstable size estimation 738a7f0b db: fix NewIter regression resulting in extra memtable levels 37558663 *: Use keyspan.LevelIter for rangedels in compactions e6c60c71 db: use sublevel level iters for all compactions out of L0 d8f63bef db: extend documentation on ingested file overlap; improve test cases b9e970a8 internal/keyspan: correct and document MergingIter key stability 498177bb internal/keyspan: collapse fragmentBoundIterator into MergingIter ``` Release note (bug fix): Fix a gap in disk-stall detection. Previously, disk stalls during filesystem metadata operations could go undetected, inducing deadlocks. Now stalls during these types of operations will correctly fatal the process.
31fa14c to
1cc2596
Compare
jbowens
left a comment
There was a problem hiding this comment.
We're green, so I'll merge this afternoon.
Reviewable status:
|
TFTR! bors r+ |
|
Build succeeded: |
This commit includes non-trivial changes to account for the change
in the
vfs.WithDiskHealthChecksfunction signature change.Additionally, this PR uncovered #81413 and necessitated some changes to
work around it.
Release note (bug fix): Fix a gap in disk-stall detection. Previously,
disk stalls during filesystem metadata operations could go undetected,
inducing deadlocks. Now stalls during these types of operations will
correctly fatal the process.