streamingccl: make completeStreamIngestion use jobs.Update API#80090
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Jun 8, 2022
Merged
streamingccl: make completeStreamIngestion use jobs.Update API#80090craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
miretskiy
approved these changes
Apr 18, 2022
Contributor
miretskiy
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @HonoreDB)
51d99f1 to
07e2000
Compare
Contributor
Author
|
bors r+ |
Contributor
|
Build failed: |
Currently we have to let call site to wait until highwater mark passed the target cutover time before setting it. Release note: None
Currently, completeStreamIngestion uses direct queries against jobs table to select the job, and update the job record. Now we are using jobs.Update api. Release note: None
07e2000 to
8740ee6
Compare
Contributor
Author
|
bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed: |
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, completeStreamIngestion uses direct queries against
jobs table to select the job, and update the job record.
Now we are using jobs.Update api.
Release note: None
Closes: #78415