80090: streamingccl: make completeStreamIngestion use jobs.Update API r=gh-casper a=gh-casper Currently, completeStreamIngestion uses direct queries against jobs table to select the job, and update the job record. Now we are using jobs.Update api. Release note: None Closes: #78415 82293: sql: support geospatial index for index recommendation indexrec r=wenyihu6 a=wenyihu6 Previously, we did not consider geospatial inverted index or box2d index for index recommendation. But for queries that use index-accelerated geospatial functions or box2d operations, the spatial index should be recommended. This PR added spatial index to index candidates. Fixes: #80934 Release note (sql change): index recommendations are now supported for spatial indexes 82482: bazel: add more detail to `dev test` cobra msg r=irfansharif,rickystewart a=msbutler Fixes #82411 Release note: None 82490: kvserver: improve the delegate snapshot code r=andreimatei a=andreimatei See individual commits. 82532: sql/sem/builtins: fix span double finish r=andreimatei a=andreimatei The tracing span was finished twice on the error path, which is illegal. Release note: None 82621: rpc: fix passing of ServerStreams to RangeFeed local RPCs r=andreimatei a=andreimatei We recently started running grpc interceptors on local RPCs (in #76306). There's a bug in there causing server-side streaming interceptors to not work as intended. A server-side streaming interceptor is supposed to wrap a streaming RPC handler and it has the option of overriding the ServerStream provided to the handler with a custom one. An RPC handler uses the ServerStream to communicate with the caller; custom implementations of ServerStream generally wrap the gRPC implementation, adding more transparent functionality (for example, they can override the Context that the handler runs in). The bug was causing the custom ServerStream provided by the interceptors to not actually be passed to the RPC handler for local RPCs (i.e. for streaming RPCs going through the internalClientAdapter - and there's only one such RPC: RangeFeed). Instead, the handler always was getting the vanilla gRPC ServerStream. The bug was in the following lines in internalClientAdapter.RangeFeed(): rfAdapter := rangeFeedServerAdapter{rangeFeedPipe: streamPipe} handler := func(srv interface{}, stream grpc.ServerStream) error { return a.server.RangeFeed(args, rfAdapter) } We're passing `rfAdapter` to a.server.RangeFeed(), when we should be passing `stream`. Making that change needs a bit of massaging, though. I've also cleaned up the code surrounding the streaming interceptors and tried to explain it better, as it was hard to follow. I've also added a test. The code still remains pretty convoluted, but I believe that that's inherently necessary given the gRPC interfaces we're working with. The bug was manifesting itself as span use-after-finish crashes in tests for the RangeFeed RPC. Because the RangeFeed handler was not using the ServerStream provided by the tracing server-side streaming interceptor, the handler was running in the client's Context, with the client-side tracing span. The client's (DistSender's) span is sometimes finished while the server-side RPC is still running, resulting in the use-after-finish. Fixes #82603 Fixes #82579 Fixes #82581 Fixes #82585 Fixes #82577 Release note: None 82637: bazel: bump size of `schemachangerccl`, `pkg/sql/catalog/lease` tests r=rail a=rickystewart Release note: None Co-authored-by: Casper <casper@cockroachlabs.com> Co-authored-by: wenyihu3 <wenyi.hu@cockroachlabs.com> Co-authored-by: Michael Butler <butler@cockroachlabs.com> Co-authored-by: Andrei Matei <andrei@cockroachlabs.com> Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com>

changefeedccl: Fix completeStreamIngestion implementation #78415

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions