cli: allow dump to be used by any user with SELECT#7974
cli: allow dump to be used by any user with SELECT#7974madelynnblue merged 1 commit intocockroachdb:masterfrom madelynnblue:cli-dump-privs
Conversation
|
Why can't we give everyone SELECT on those tables? On Jul 22, 2016 03:21, "Matt Jibson" notifications@github.com wrote:
|
|
Multi-tenancy wouldn't want to let every user see everyone else's schema, I think. |
|
Whether that's it or not, a comment somewhere would be good. |
|
Right, but then we'd also need to show non-root users to create tables. On Jul 22, 2016 06:46, "Tobias Schottdorf" notifications@github.com wrote:
|
The previous version used a SELECT to fetch from the system.descriptor table. This thus required SELECT on that table, which only root has. Instead of adding some way around this like a new API call, use the existing SHOW statements to fetch the same data (although not as elegantly). Fixes #7964
|
Added a comment about multi-tenancy. @tamir either you have a grammar error in your last comment or I don't understand it. Could you rephrase? Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
|
s/show/allow/ On Jul 22, 2016 15:04, "Matt Jibson" notifications@github.com wrote:
|
|
LGTM, though I didn't dig into the details so someone more qualified should. Reviewed 1 of 1 files at r1, 1 of 1 files at r2. Comments from Reviewable |
|
BTW, add a TODO (or issue) that uses |
|
LGTM. +1 on a TODO referring to information_schema. Review status: Comments from Reviewable |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.|
Docs updated with cockroachdb/docs#511 |
The previous version used a SELECT to fetch from the system.descriptor
table. This thus required SELECT on that table, which only root has. Instead
of adding some way around this like a new API call, use the existing SHOW
statements to fetch the same data (although not as elegantly).
Fixes #7964
This change is