Skip to content

release-22.1: sql: Node user always passes CheckAnyPrivilege#79098

Merged
rafiss merged 1 commit intorelease-22.1from
blathers/backport-release-22.1-79048
Mar 31, 2022
Merged

release-22.1: sql: Node user always passes CheckAnyPrivilege#79098
rafiss merged 1 commit intorelease-22.1from
blathers/backport-release-22.1-79048

Conversation

@blathers-crl
Copy link
Copy Markdown

@blathers-crl blathers-crl bot commented Mar 30, 2022 •
edited by rafiss
Loading

Backport 1/1 commits from #79048 on behalf of @RichardJCai.

/cc @cockroachdb/release

No release note since this only affects what is shown
in InternalExecutor queries.

Release note: None

Release justification: low risk bug fix

@RichardJCai
sql: Node user always passes CheckAnyPrivilege
34abf57 
No release note since this only affects what is shown
in InternalExecutor queries.

Release note: None
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-79048 branch from 5215b3c to 34abf57 Compare March 30, 2022 22:45
@blathers-crl blathers-crl bot requested a review from rafiss March 30, 2022 22:45
@blathers-crl
Copy link
Copy Markdown
Author

blathers-crl bot commented Mar 30, 2022 •
edited by RichardJCai
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 30, 2022
@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Mar 30, 2022

This change is Reviewable

@rafiss rafiss merged commit 8b41b18 into release-22.1 Mar 31, 2022
@rafiss rafiss deleted the blathers/backport-release-22.1-79048 branch March 31, 2022 16:47
@rafiss rafiss mentioned this pull request Apr 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rafiss rafiss rafiss approved these changes

Assignees

@RichardJCai RichardJCai

Labels

blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cockroach-teamcity @rafiss @RichardJCai