Skip to content

sql: Node user always passes CheckAnyPrivilege#79048

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
RichardJCai:node_user_always_passes_check_any_privilege
Mar 30, 2022
Merged

sql: Node user always passes CheckAnyPrivilege#79048
craig[bot] merged 1 commit intocockroachdb:masterfrom
RichardJCai:node_user_always_passes_check_any_privilege

Conversation

@RichardJCai
Copy link
Copy Markdown
Contributor

No release note since this only affects what is shown
in InternalExecutor queries.

Release note: None

@RichardJCai RichardJCai requested review from a team and rafiss March 30, 2022 16:13
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! it's hard to say whether this is a regression, but i guess ultimately it won't hurt to backport all the way to 21.1

No release note since this only affects what is shown
in InternalExecutor queries.

Release note: None
@RichardJCai RichardJCai force-pushed the node_user_always_passes_check_any_privilege branch from e61ade0 to db476bd Compare March 30, 2022 19:00
@RichardJCai
Copy link
Copy Markdown
Contributor Author

The only test failure is a flake which is fixed on master.

bors r=rafiss

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 30, 2022

Build succeeded:

@craig craig bot merged commit 093d5cf into cockroachdb:master Mar 30, 2022
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Mar 30, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from db476bd to blathers/backport-release-21.1-79048: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.1.x failed. See errors above.


error creating merge commit from db476bd to blathers/backport-release-21.2-79048: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants