loqrecovery: fix json field name in replica info file#77301
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 8, 2022
Merged
loqrecovery: fix json field name in replica info file#77301craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
96593e4 to
6384cd0
Compare
6384cd0 to
9641854
Compare
erikgrinaker
approved these changes
Mar 3, 2022
Contributor
|
Btw, why wasn't this picked up by any end-to-end tests? Do we lack sufficient coverage? |
Contributor
Author
|
It was picked up by the roachtest that is not merged yet. But we didn't have a specific test that manages to create a descriptor update for the TestCluster and recover from it. This seem to me like a "bug" in gogoproto or marshaller where marshalling to json generates data that can't be unmarshalled back. I don't think we should be trying to cover all the underlying libraries beside basics. |
cb32996 to
75b55cb
Compare
Contributor
Sure, but presumably this caused some functionality to break, which indicates gaps in our end-to-end testing. |
c20ec33 to
92c93aa
Compare
Previously protobuf used camelcase name for repeated field for descriptor change. This was wrong as it was not parsed correctly by marshaller. This fix adds explicit name to proto specification to avoid default name generation. Release justification: This change is low risk as it fixes a bug in new functionality. Release note: None
92c93aa to
ef9f4fb
Compare
Contributor
Author
|
bors r=erikgrinaker |
Contributor
|
Build failed: |
Contributor
Author
|
bors r=erikgrinaker |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
craig bot
pushed a commit
that referenced
this pull request
Mar 7, 2022
76611: roachpb: add lock table metadata structures r=AlexTalks a=AlexTalks This change adds the protobuf structures, as well as the method, needed to capture the state of a replica's lock table. This is part of the work coming out of #75541, and is needed to be able to implement the `QueryLocks` RPC. Release note: None 77159: roachtest/tests: move prometheus client interface to separate package r=irfansharif a=ajwerner This way mockgen does not depend on the `roachtest/tests` package. Touches #76851. Release justification: non-production code change Release note: None 77301: loqrecovery: fix json field name in replica info file r=erikgrinaker a=aliher1911 Previously protobuf used camelcase name for repeated field for descriptor change. This was wrong as it was not parsed correctly by marshaller. This fix adds explicit name to proto specification to avoid default name generation. Release justification: This change is low risk as it fixes a bug in new functionality. Release note: None Fixes #77282 Co-authored-by: Alex Sarkesian <sarkesian@cockroachlabs.com> Co-authored-by: Andrew Werner <awerner32@gmail.com> Co-authored-by: Oleg Afanasyev <oleg@cockroachlabs.com>
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously protobuf used camelcase name for repeated field
for descriptor change. This was wrong as it was not parsed
correctly by marshaller.
This fix adds explicit name to proto specification to avoid
default name generation.
Release justification: This change is low risk as it fixes
a bug in new functionality.
Release note: None
Fixes #77282