sql: execute batch statements in an implicit transaction by rafiss · Pull Request #76834 · cockroachdb/cockroach

rafiss · 2022-02-20T23:26:17Z

fixes #44803
relates to #76490

Release justification: high value bug fix to existing functionality

*: prepare tests for batch stmt txn change

This commit will make the next one easier to review.

sql: execute batch statements in an implicit transaction

Release note (bug fix): Previously statements that arrived in a batch
during the simple query protocol would all execute in their own implicit
transactions. Now, we match the Postgres wire protocol, so all these
statements share the same implicit transaction. If a BEGIN is included
in a statement batch, then the existing implicit transaction is
upgraded to an explicit transaction.

sql: add session var for old implicit txn behavior

Release note (sql change): The enable_implicit_transaction_for_batch_statements
session variable was added. It defaults to true. When it is true,
multiple statements in a single query (a.k.a. a "batch statement") will
all be run in the same implicit transaction, which matches the Postgres
wire protocol. This setting is provided for users who want to preserve
the behavior of CockroachDB versions v21.2 and earlier.

cockroach-teamcity · 2022-02-20T23:26:30Z

This change is

otan

change by itself lgtm, but i think this may cause some tests to fail as they use multiple schema changes in the same cmd. the test failures seem suspicious as a result.

craig · 2022-03-15T14:16:38Z

Canceled.

rafiss · 2022-03-15T14:32:12Z

bors r=otan

76834: sql: execute batch statements in an implicit transaction r=otan a=rafiss fixes #44803 relates to #76490 Release justification: high value bug fix to existing functionality ### *: prepare tests for batch stmt txn change This commit will make the next one easier to review. ### sql: execute batch statements in an implicit transaction Release note (bug fix): Previously statements that arrived in a batch during the simple query protocol would all execute in their own implicit transactions. Now, we match the Postgres wire protocol, so all these statements share the same implicit transaction. If a BEGIN is included in a statement batch, then the existing implicit transaction is upgraded to an explicit transaction. ### sql: add session var for old implicit txn behavior Release note (sql change): The enable_implicit_transaction_for_batch_statements session variable was added. It defaults to true. When it is true, multiple statements in a single query (a.k.a. a "batch statement") will all be run in the same implicit transaction, which matches the Postgres wire protocol. This setting is provided for users who want to preserve the behavior of CockroachDB versions v21.2 and earlier. 77780: roachtest: update 22.1 version map to v21.2.7 r=celiala a=Azhng Release note: None Release justification: non-production code change. 77781: cloud: bump orchestrator to v21.2.7 r=celiala a=Azhng Release note: None Release justification: non-production code change. 77803: kvserverbase: move MaxCommandSizeDefault out of kvserver r=ajwerner a=ajwerner ``` $ bazel query "somepath(//pkg/sql, //pkg/kv/kvserver)" INFO: Empty results Loading: 0 packages loaded ``` Release justification: non-production code changes Release note: None Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com> Co-authored-by: Azhng <archer.xn@gmail.com> Co-authored-by: Andrew Werner <awerner32@gmail.com>

craig · 2022-03-15T15:52:46Z

Canceled.

rafiss · 2022-03-15T16:56:00Z

bors r=otan

rafiss · 2022-03-15T18:35:03Z

bors r-

This commit will make the next one easier to review. Release justification: test only change Release note: None

Release justification: high value bug fix to existing functionality. Release note (bug fix): Previously statements that arrived in a batch during the simple query protocol would all execute in their own implicit transactions. Now, we match the Postgres wire protocol, so all these statements share the same implicit transaction. If a BEGIN is included in a statement batch, then the existing implicit transaction is upgraded to an explicit transaction.

Release justification: low risk new setting. Release note (sql change): The enable_implicit_transaction_for_batch_statements session variable was added. It defaults to true. When it is true, multiple statements in a single query (a.k.a. a "batch statement") will all be run in the same implicit transaction, which matches the Postgres wire protocol. This setting is provided for users who want to preserve the behavior of CockroachDB versions v21.2 and earlier.

rafiss · 2022-03-15T20:47:52Z

bors r=otan

craig · 2022-03-15T22:07:37Z

Build succeeded:

GitHub CI (Cockroach)

blathers-crl · 2022-03-15T22:07:43Z

Encountered an error creating backports. Some common things that can go wrong:

The backport branch might have already existed.
There was a merge conflict.
The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

error creating backport branch refs/heads/blathers/backport-release-21.2-76834: POST https://api.github.com/repos/cockroachlabs/cockroach/git/refs: 403 Resource not accessible by integration []

Backport to branch 21.2.x failed. See errors above.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}

rafiss requested a review from andreimatei February 20, 2022 23:26

rafiss force-pushed the batch-stmt-implicit-txn branch 2 times, most recently from c4f5971 to 7205a02 Compare February 21, 2022 22:58

rafiss requested review from a team and otan February 21, 2022 23:18

rafiss force-pushed the batch-stmt-implicit-txn branch from 7205a02 to 417fddf Compare February 22, 2022 17:56

rafiss mentioned this pull request Feb 22, 2022

pgwire: bad handling of error in multi-statement query #72769

Closed

rafiss force-pushed the batch-stmt-implicit-txn branch 2 times, most recently from bd01597 to 1cde010 Compare February 22, 2022 20:57

otan reviewed Feb 23, 2022

View reviewed changes

rafiss force-pushed the batch-stmt-implicit-txn branch from 1cde010 to 1073168 Compare February 25, 2022 18:26

rafiss requested a review from a team as a code owner February 25, 2022 18:26

rafiss requested a review from a team February 25, 2022 18:26

rafiss requested a review from a team as a code owner February 25, 2022 18:26

rafiss requested review from a team and stevendanna and removed request for a team February 25, 2022 18:26

blathers-crl bot requested a review from otan February 25, 2022 18:26

rafiss force-pushed the batch-stmt-implicit-txn branch from 1073168 to d463dea Compare February 25, 2022 22:50

rafiss requested a review from a team as a code owner February 25, 2022 22:50

rafiss requested review from a team and removed request for a team February 28, 2022 16:28

rafiss force-pushed the batch-stmt-implicit-txn branch from d463dea to 38d4cf7 Compare February 28, 2022 20:29

rafiss requested a review from a team as a code owner February 28, 2022 20:29

rafiss force-pushed the batch-stmt-implicit-txn branch 2 times, most recently from 49d30bc to 8ea59b7 Compare March 1, 2022 07:12

rafiss requested a review from a team as a code owner March 1, 2022 07:12

rafiss force-pushed the batch-stmt-implicit-txn branch from 8ea59b7 to e138f8a Compare March 1, 2022 19:48

rafiss force-pushed the batch-stmt-implicit-txn branch from 53ecf6c to 3f45266 Compare March 15, 2022 15:52

rafiss added the backport-21.2.x label Mar 15, 2022

rafiss added 3 commits March 15, 2022 15:15

*: prepare tests for batch stmt txn change

6700a17

This commit will make the next one easier to review. Release justification: test only change Release note: None

rafiss force-pushed the batch-stmt-implicit-txn branch from 3f45266 to 4fc43c8 Compare March 15, 2022 19:15

craig bot merged commit cfe38f2 into cockroachdb:master Mar 15, 2022

cockroach-teamcity mentioned this pull request Mar 15, 2022

sql: execute batch statements in an implicit transaction cockroachdb/docs#13254

Closed

rafiss mentioned this pull request Mar 15, 2022

release-22.1: sql: execute batch statements in an implicit transaction #77865

Merged

This was referenced Mar 16, 2022

roachtest: sqlsmith/setup=tpcc/setting=ddl-nodrop failed #77887

Closed

roachtest: cancel/tpch/local/queries=7,9,20,21,nodes=3 failed #77902

Closed

rafiss deleted the batch-stmt-implicit-txn branch March 16, 2022 20:04

ajwerner mentioned this pull request Mar 18, 2022

roachtest: alterpk-bank failed #71390

Closed

rafiss mentioned this pull request Mar 19, 2022

roachtest: psycopg failed #78078

Closed

ajwerner removed the backport-21.2.x label Mar 29, 2022

ajwerner mentioned this pull request Mar 29, 2022

sql: detection of single-statement implicit transactions broken in batch #78970

Closed

xinhaoz mentioned this pull request Jul 7, 2022

release-22.1: sql: add txn_fingerprint_id to node_statement_statistics #84020

Merged

This was referenced Dec 15, 2022

Added enable_implicit_transaction_for_batch_statements to v22.2 release notes cockroachdb/docs#15836

Merged

Certain types of schema changes don't work with CockroachDB v22.2 prisma/prisma#16909

Closed

ajwerner mentioned this pull request Feb 27, 2023

race condition between ADD COLUMN and a subsequent UPDATE #97706

Closed

ferdypruis mentioned this pull request Aug 28, 2023

sql: support transactionally dropping a column and creating one with the same name #109587

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sql: execute batch statements in an implicit transaction#76834

sql: execute batch statements in an implicit transaction#76834
craig[bot] merged 3 commits intocockroachdb:masterfrom
rafiss:batch-stmt-implicit-txn

rafiss commented Feb 20, 2022 •

edited

Loading

Uh oh!

cockroach-teamcity commented Feb 20, 2022

Uh oh!

otan left a comment

Uh oh!

craig bot commented Mar 15, 2022

Uh oh!

rafiss commented Mar 15, 2022

Uh oh!

craig bot commented Mar 15, 2022

Uh oh!

rafiss commented Mar 15, 2022

Uh oh!

rafiss commented Mar 15, 2022

Uh oh!

rafiss commented Mar 15, 2022

Uh oh!

craig bot commented Mar 15, 2022

Uh oh!

blathers-crl bot commented Mar 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

rafiss commented Feb 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

*: prepare tests for batch stmt txn change

sql: execute batch statements in an implicit transaction

sql: add session var for old implicit txn behavior

Uh oh!

cockroach-teamcity commented Feb 20, 2022

Uh oh!

otan left a comment

Choose a reason for hiding this comment

Uh oh!

craig bot commented Mar 15, 2022

Uh oh!

rafiss commented Mar 15, 2022

Uh oh!

craig bot commented Mar 15, 2022

Uh oh!

rafiss commented Mar 15, 2022

Uh oh!

rafiss commented Mar 15, 2022

Uh oh!

rafiss commented Mar 15, 2022

Uh oh!

craig bot commented Mar 15, 2022

Uh oh!

blathers-crl bot commented Mar 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rafiss commented Feb 20, 2022 •

edited

Loading