server: standardize error handling across all RPC endpoints#76292
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 10, 2022
Merged
server: standardize error handling across all RPC endpoints#76292craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
26fb9c1 to
a45cb60
Compare
a45cb60 to
bee6c28
Compare
Contributor
Author
Arguably, there is still a lot of boilerplate in here, so a later iteration of this work could consider handling errors at a higher level. However, before we can do this we want all the API handlers to handle errors in a consistent manner, so that there's no surprise left during the later refactoring. This change also takes care of logging a few errors that were not logged before. Release note: None
bee6c28 to
d679dd0
Compare
jocrl
approved these changes
Feb 9, 2022
Contributor
jocrl
left a comment
There was a problem hiding this comment.
Thanks! The comment and highlight of other examples to fix the bug is helpful and looks good.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @dhartunian, @maryliag, and @rimadeodhar)
Contributor
Author
|
Thanks josephine! bors r=jocrl |
Contributor
|
Build succeeded: |
craig bot
pushed a commit
that referenced
this pull request
Feb 11, 2022
76294: server: make the Drain interfaces available to SQL-only servers r=cameronnunez,JeffSwenson a=knz Fixes #74412 First commit from #76292; the reviewers are invited to ignore it in this PR. See individual commits for details. cc @cockroachdb/obs-inf-prs Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arguably, there is still a lot of boilerplate in here, so a later
iteration of this work could consider handling errors at a higher
level.
However, before we can do this we want all the API handlers to handle
errors in a consistent manner, so that there's no surprise left during
the later refactoring.
This change also takes care of logging a few errors that were not
logged before.
Release note: None