Skip to content

execbuilder: skip flaky hash-sharded tests#75962

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
mgartner:skip-execbuilder-test
Feb 3, 2022
Merged

execbuilder: skip flaky hash-sharded tests#75962
craig[bot] merged 1 commit intocockroachdb:masterfrom
mgartner:skip-execbuilder-test

Conversation

@mgartner
Copy link
Copy Markdown
Contributor

@mgartner mgartner commented Feb 3, 2022

Informs #75960

Release note: None

@mgartner mgartner requested a review from a team as a code owner February 3, 2022 16:43
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Member

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @chengxiong-ruan and @stevendanna)

@mgartner
Copy link
Copy Markdown
Contributor Author

mgartner commented Feb 3, 2022

bors r+ p=9999

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Feb 3, 2022

Build succeeded:

@craig craig bot merged commit 394677d into cockroachdb:master Feb 3, 2022
@mgartner mgartner deleted the skip-execbuilder-test branch February 3, 2022 18:46
mgartner added a commit to mgartner/cockroach that referenced this pull request Feb 3, 2022
This commit de-flakes tests that were previously disabled in cockroachdb#75962 by
setting column families explicitly. I originally thought these
execbuilder tests were flaky because there were two query plans with the
same cost, but the flakiness was actually the result of randomized
families in logic tests.

Fixes cockroachdb#75960

Release note: None
@chengxiong-ruan
Copy link
Copy Markdown
Contributor

oh boy, looks like I was just lucky enough to have them all passed in my previous pr.
Thanks for planning to fix them.

craig bot pushed a commit that referenced this pull request Feb 4, 2022
73701: sqlsmith: enhance tlp to test predicate projections and DISTINCTs r=jordanlewis a=jordanlewis

This commit enhances the WHERE tlp generator to also output the
projection of the predicates in both the partitioned and unpartitioned
query outputs. The purpose of this enhanced testing is to make sure that
projection output always matches filter output, and that projection
output for all 3 partitions is identical in every partition and in the
non-partitioned case as well. 

Also, add a DISTINCT oracle.

The DISTINCT oracle for TLP generates unpartitioned queries of the
following form:

SELECT DISTINCT {cols...} FROM t

and partitioned queries of the following form:

SELECT DISTINCT {cols...} FROM t WHERE pred UNION ALL
SELECT DISTINCT {cols...} FROM t WHERE NOT (pred) UNION ALL
SELECT DISTINCT {cols...} FROM t WHERE (pred) IS NULL

Release note: None

75971: sql: enable storage parameter syntax for primary key r=chengxiong-ruan a=chengxiong-ruan

This is a prerequisite to support `WITH (bucket_count=...)` syntax
for hash sharded index.

Release note (sql change): Previously, `WITH (param=value)` syntax
is not allowed for primary key. However, that does not align with
postgresql. Also, to support `WITH (bucket_count=...)` syntax for hash
sharded index, we need to enable it as well. This pr also adds
extra validation to prevent existing storage params from being
applied to primary keys. Which means, even the syntax is accepted
by the parser, none of existing storage param for inverted index
is allowed on primary key. We don't actually set those params
on top of PKs internally, but we need to tell user which param is
supprted or not. Eventually, when we add support for `bucket_count`
param, a param white list will be maintained for PKs.

75972: execbuilder: re-enable skipped tests r=mgartner a=mgartner

This commit de-flakes tests that were previously disabled in #75962 by
setting column families explicitly. I originally thought these
execbuilder tests were flaky because there were two query plans with the
same cost, but the flakiness was actually the result of randomized
families in logic tests.

Fixes #75960

Release note: None

Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Co-authored-by: Chengxiong Ruan <chengxiongruan@gmail.com>
Co-authored-by: Marcus Gartner <marcus@cockroachlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants