execbuilder: skip flaky hash-sharded tests#75962
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 3, 2022
Merged
execbuilder: skip flaky hash-sharded tests#75962craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Informs cockroachdb#75960 Release note: None
Member
RaduBerinde
approved these changes
Feb 3, 2022
Member
RaduBerinde
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @chengxiong-ruan and @stevendanna)
Contributor
Author
|
bors r+ p=9999 |
stevendanna
approved these changes
Feb 3, 2022
Contributor
|
Build succeeded: |
mgartner
added a commit
to mgartner/cockroach
that referenced
this pull request
Feb 3, 2022
This commit de-flakes tests that were previously disabled in cockroachdb#75962 by setting column families explicitly. I originally thought these execbuilder tests were flaky because there were two query plans with the same cost, but the flakiness was actually the result of randomized families in logic tests. Fixes cockroachdb#75960 Release note: None
Contributor
|
oh boy, looks like I was just lucky enough to have them all passed in my previous pr. |
craig bot
pushed a commit
that referenced
this pull request
Feb 4, 2022
73701: sqlsmith: enhance tlp to test predicate projections and DISTINCTs r=jordanlewis a=jordanlewis
This commit enhances the WHERE tlp generator to also output the
projection of the predicates in both the partitioned and unpartitioned
query outputs. The purpose of this enhanced testing is to make sure that
projection output always matches filter output, and that projection
output for all 3 partitions is identical in every partition and in the
non-partitioned case as well.
Also, add a DISTINCT oracle.
The DISTINCT oracle for TLP generates unpartitioned queries of the
following form:
SELECT DISTINCT {cols...} FROM t
and partitioned queries of the following form:
SELECT DISTINCT {cols...} FROM t WHERE pred UNION ALL
SELECT DISTINCT {cols...} FROM t WHERE NOT (pred) UNION ALL
SELECT DISTINCT {cols...} FROM t WHERE (pred) IS NULL
Release note: None
75971: sql: enable storage parameter syntax for primary key r=chengxiong-ruan a=chengxiong-ruan
This is a prerequisite to support `WITH (bucket_count=...)` syntax
for hash sharded index.
Release note (sql change): Previously, `WITH (param=value)` syntax
is not allowed for primary key. However, that does not align with
postgresql. Also, to support `WITH (bucket_count=...)` syntax for hash
sharded index, we need to enable it as well. This pr also adds
extra validation to prevent existing storage params from being
applied to primary keys. Which means, even the syntax is accepted
by the parser, none of existing storage param for inverted index
is allowed on primary key. We don't actually set those params
on top of PKs internally, but we need to tell user which param is
supprted or not. Eventually, when we add support for `bucket_count`
param, a param white list will be maintained for PKs.
75972: execbuilder: re-enable skipped tests r=mgartner a=mgartner
This commit de-flakes tests that were previously disabled in #75962 by
setting column families explicitly. I originally thought these
execbuilder tests were flaky because there were two query plans with the
same cost, but the flakiness was actually the result of randomized
families in logic tests.
Fixes #75960
Release note: None
Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Co-authored-by: Chengxiong Ruan <chengxiongruan@gmail.com>
Co-authored-by: Marcus Gartner <marcus@cockroachlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Informs #75960
Release note: None