ui: Add CircleFilled component#75807
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 2, 2022
Merged
Conversation
Member
|
This change is |
maryliag
approved these changes
Feb 1, 2022
Contributor
maryliag
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained
Author
|
bors r+ |
Author
|
bors r- |
Contributor
|
Canceled. |
Previously, there was no component for a filled circle icon in the ui package. Recent product designs have requested this icon for the DB Console (see cockroachdb#67510, cockroachdb#73463). This PR adds a CircleFilled component to the ui package. Release note: None
564955f to
a674c28
Compare
Author
|
The Bazel CI keeps failing for this PR. It looks like a timeout that is unrelated to the changes made in this PR. Any objections to just ignoring the Bazel CI, as it's technically optional, and merging? |
Contributor
|
No objections, you can go ahead with the merge |
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, there was no component for a filled circle icon in the
uipackage.Recent product designs have requested this icon for the DB Console (see #67510, #73463).
This PR adds a
CircleFilledcomponent to theuipackage.Release note: None