sql: implement the ALTER TABLE ... SET (...) syntax#75262
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Jan 26, 2022
Merged
sql: implement the ALTER TABLE ... SET (...) syntax#75262craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
596d4c7 to
7db8c95
Compare
ecd18ec to
7db8c95
Compare
rafiss
approved these changes
Jan 26, 2022
Collaborator
rafiss
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @otan)
Release note (sql change): Added pgcodes to errors when an invalid storage parameter is passed.
Release note (sql change): Implemented the `ALTER TABLE ... SET (...)` syntax. This mostly no-ops as we do not support any storage parameters (yet).
Contributor
Author
|
bors r=rafiss |
Contributor
|
Build succeeded: |
This was referenced Jan 26, 2022
craig bot
pushed a commit
that referenced
this pull request
Jan 27, 2022
75429: parser: implement ALTER TABLE ... RESET (...) r=rafiss a=otan Only last two commits for review (rest is #75262). See individual commits for details. 75464: *: use bootstrap.BootstrappedSystemIDChecker in tests r=postamar a=postamar Instead of relying on hard-coded constants, tests now rely on the bootstrapped system schema to determine which IDs belong to system tables or not. Release note: None 75561: sql/tests: skip st_buffer in randomized test r=otan a=rafiss fixes #74078 Release note: None 75598: kvserver: deflake TestBackpressureNotAppliedWhenReducingRangeSize r=irfansharif a=irfansharif This test relies on a second node's span config rangefeed to have caught up sufficiently with the global state such that a snapshot, when applied, would construct a replica with the config this test attempts to declare over the originating replica. Though very unlikely to occur (repro-ed only once in hours GCE worker runs), it's possible. This patch is a speculative fix for a failure observed only with manual stressing on a SHA that included #75233. (Also make some prominent span config logging a bit more consistent with one another.) Release note: None Co-authored-by: Oliver Tan <otan@cockroachlabs.com> Co-authored-by: Marius Posta <marius@cockroachlabs.com> Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com> Co-authored-by: irfan sharif <irfanmahmoudsharif@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see individual commits for details.
prep work for TTL.