Skip to content

authors: add sherman-grewal to authors#74418

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
sherman-grewal:shermangrewal_authors
Jan 5, 2022
Merged

authors: add sherman-grewal to authors#74418
craig[bot] merged 1 commit intocockroachdb:masterfrom
sherman-grewal:shermangrewal_authors

Conversation

@sherman-grewal
Copy link
Copy Markdown

@sherman-grewal sherman-grewal commented Jan 4, 2022

Release note: None

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Jan 4, 2022

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

I was unable to automatically find a reviewer. You can try CCing one of the following members:

  • A person you worked with closely on this PR.
  • The person who created the ticket, or a CRDB organization member involved with the ticket (author, commenter, etc.).
  • Join our community slack channel and ask on #contributors.
  • Try find someone else from here.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Jan 4, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-untriaged blathers was unable to find an owner labels Jan 4, 2022
@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Jan 4, 2022

This change is Reviewable

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Jan 4, 2022

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have some potential action items for you:

  • We notice you have more than one commit in your PR. We try break logical changes into separate commits, but commits such as "fix typo" or "address review commits" should be squashed into one commit and pushed with --force
  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

I was unable to automatically find a reviewer. You can try CCing one of the following members:

  • A person you worked with closely on this PR.
  • The person who created the ticket, or a CRDB organization member involved with the ticket (author, commenter, etc.).
  • Join our community slack channel and ask on #contributors.
  • Try find someone else from here.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Jan 4, 2022

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

I was unable to automatically find a reviewer. You can try CCing one of the following members:

  • A person you worked with closely on this PR.
  • The person who created the ticket, or a CRDB organization member involved with the ticket (author, commenter, etc.).
  • Join our community slack channel and ask on #contributors.
  • Try find someone else from here.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@sherman-grewal sherman-grewal requested a review from jlinder January 5, 2022 15:12
jlinder
jlinder approved these changes Jan 5, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jlinder jlinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

To merge this, ask Craig (our Bors bot) to merge by writing a comment with a line containing bors r+.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @sherman-grewal)

@sherman-grewal
Copy link
Copy Markdown
Author

sherman-grewal commented Jan 5, 2022

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 5, 2022

🔒 Permission denied

Existing reviewers: click here to make sherman-grewal a reviewer

@sherman-grewal
Copy link
Copy Markdown
Author

sherman-grewal commented Jan 5, 2022

bors r+

craig bot pushed a commit that referenced this pull request Jan 5, 2022
@adityamaru
Merge #74281 #74418
669bef4 
74281: migrations: add target column to system.pts_records r=ajwerner,irfansharif a=adityamaru

This change adds a `BYTES` column to the system.pts_records
table, that will store an encoded protocol buffer
representing the `Target` on a protected timestamp
record. We do not populate the column in this PR, that will
be done in a followup.

Additionally, we add a tenant migration to `ALTER TABLE ... ADD COLUMN`
to run on the upgrade path for older clusters.

Informs: #73727

Release note (sql change): `system.protected_timestamp_records` table
now has an additional `target` column that will store an encoded
protobuf that represents the target a record protects. This target
can either be the entire cluster, tenants, or schema objects
(databases/tables).

74418: authors: add sherman-grewal to authors r=sherman-grewal a=sherman-grewal

Release note: None

Co-authored-by: Aditya Maru <adityamaru@gmail.com>
Co-authored-by: Sherman Grewal <sherman.grewal@cockroachlabs.com>
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 5, 2022

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 5, 2022

Build succeeded:

@craig craig bot merged commit ab06144 into cockroachdb:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlinder jlinder jlinder approved these changes

Assignees

No one assigned

Labels

O-community Originated from the community X-blathers-untriaged blathers was unable to find an owner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sherman-grewal @cockroach-teamcity @jlinder