ui: return expectSagas to test runner#73180
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Nov 26, 2021
Merged
Conversation
Previsouly, sqlStatsSaga tests use `expectSaga` function to verify the saga correctnes. However, the Promise returned by `expectSaga` function was not returned to the test runner, this resulted in all the tests be effectively noop. This commit returned the Promise returend by `expectSaga` to test runner. Release note: None
Member
|
This change is |
maryliag
approved these changes
Nov 26, 2021
Contributor
maryliag
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained
Contributor
Author
|
TFTR! bors r=maryliag |
Contributor
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 837bf9e to blathers/backport-release-21.2-73180: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 21.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Contributor
Author
|
Hmm seems like this need to wait til #73148 to merge in. |
Contributor
Author
|
blathers backport 21.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previsouly, sqlStatsSaga tests use
expectSagafunction toverify the saga correctnes. However, the Promise returned by
expectSagafunction was not returned to the test runner,this resulted in all the tests be effectively noop.
This commit returned the Promise returend by
expectSagatotest runner.
Release note: None