release-21.2: ui: unify cluster-ui stores for Statement and Transaction Page#73148
Merged
Azhng merged 1 commit intorelease-21.2from Nov 26, 2021
Merged
Conversation
Previously, on CC Conosle, Statement Page and Transaction Page were backed by their own Redux stores and their own Redux Sagas. However, both Statement and Transaction Page were backed by a single API endpoint, namely `/_status/statements`. This resulted in unnecessary API calls and bugs like #72009, which was caused by Reset SQL Stats sagas failing to reset the Transaction Page Redux store. This commit unifies the following Redux store and sagas into a single store / sagas: 1. Statement Page store / sagas 2. Transaciton Page store / sagas 3. Reset SQL Stats store / sagas This greatly removed the code duplication and test duplication and simplify the logic. Statement Page and Transaction Page can reuse the same store by their own selectors. Resolves #72009 Release note: None
0a1c10b to
3d94480
Compare
Author
|
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
Member
|
This change is |
maryliag
approved these changes
Nov 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #72627 on behalf of @Azhng.
/cc @cockroachdb/release
Previously, on CC Conosle, Statement Page and Transaction Page were backed by
their own Redux stores and their own Redux Sagas. However, both Statement
and Transaction Page were backed by a single API endpoint, namely
/_status/statements. This resulted in unnecessary API calls and bugslike #72009, which was caused by Reset SQL Stats sagas failing to
reset the Transaction Page Redux store.
This commit unifies the following Redux store and sagas into a single
store / sagas:
This greatly removed the code duplication and test duplication and simplify
the logic. Statement Page and Transaction Page can reuse the same store
by their own selectors.
Resolves #72009
Release note: None
CC Console:
cc.mov
DB Console:
Screen.Recording.2021-11-09.at.23.07.17.mov
Release justification: Low risk, high benefit changes to existing functionality