tabledesc: improve index column ID and name validation#73142
tabledesc: improve index column ID and name validation#73142craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
|
This validation is not gated behind any descriptor version formats. Existing corrupted edit: I got scared for nothing and DROP COLUMN works just fine and so I don't expect any primary index descriptors to be corrupted at all. |
ad078c8 to
088bb66
Compare
|
This is interesting. The ADD COLUMN test case in TestRollback is hanging, and this is because we're failing these new validation checks in the rollbacks. I haven't yet found the bug in the declarative schema changer's ADD COLUMN implementation, instead I made some improvements to that test suite so that it wouldn't hang: I also made these driven by the side-effects test definitions, which is quite nice here because it makes it easy to see where the problem is. Here, bad things happen when failing the validation ops stage after backfilling. |
This commit adds missing index column ID and name validation, in particular concerning stored- and key-suffix-columns. Fixes cockroachdb#72771. Release note: None
088bb66 to
218f887
Compare
ajwerner
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @postamar)
|
Thanks for the review! bors r+ |
|
Build succeeded: |
This commit adds missing index column ID and name validation, in
particular concerning stored- and key-suffix-columns.
Fixes #72771.
Release note: None