schemachanger: make rollback tests data-driven#73177
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Nov 26, 2021
Merged
schemachanger: make rollback tests data-driven#73177craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
ebe3f13 to
22c91a4
Compare
fqazi
reviewed
Nov 25, 2021
Collaborator
fqazi
left a comment
There was a problem hiding this comment.
LGTM!
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @postamar)
fqazi
approved these changes
Nov 25, 2021
Collaborator
fqazi
left a comment
There was a problem hiding this comment.
Reviewable status:
22c91a4 to
7fe39a3
Compare
Author
|
Thanks for the review! I force-pushed some changes which should make |
fqazi
approved these changes
Nov 25, 2021
Collaborator
fqazi
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
We recently introduced a TestRollback suite in the schemachanger package to test the declarative schema changer's behavior in the face of rollbacks. This commit rewrites this test suite to make it data-driven, also it now consumes exactly the same test cases as the side-effects tests. This is possible because the rollback tests don't have any expected output (they only pass or fail). This is desirable because we want these tests to be executed on an equally wide variety of cases. This commit also adds a timeout on the execution of the test statements to prevent them from hanging due to unrelated failures. Release note: None
7fe39a3 to
af7b6b5
Compare
Author
|
Just some more cosmetic changes. bors r+ |
Contributor
|
Build failed: |
Author
|
Failure seems completely unrelated 😕 bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently introduced a TestRollback suite in the schemachanger package
to test the declarative schema changer's behavior in the face of
rollbacks. This commit rewrites this test suite to make it data-driven,
also it now consumes exactly the same test cases as the side-effects
tests. This is possible because the rollback tests don't have any
expected output (they only pass or fail). This is desirable because we
want these tests to be executed on an equally wide variety of cases.
This commit also adds a timeout on the execution of the test statements
to prevent them from hanging due to unrelated failures.
Release note: None