clusterversion: introduce 22.1 development versions#71836
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Oct 22, 2021
Merged
clusterversion: introduce 22.1 development versions#71836craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
irfansharif
approved these changes
Oct 21, 2021
| { | ||
| Key: Start22_1, | ||
| Version: roachpb.Version{Major: 22, Minor: 1, Internal: 100}, | ||
| Version: roachpb.Version{Major: 21, Minor: 2, Internal: 100}, |
Contributor
There was a problem hiding this comment.
Can we make the Internal counter start at 2? The 100 was just an artifact from last release.
c3fc2e9 to
cd54ef1
Compare
celiala
commented
Oct 21, 2021
Collaborator
Author
celiala
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @irfansharif)
a discussion (no related file):
TFTR!
pkg/clusterversion/cockroach_versions.go, line 512 at r1 (raw file):
Previously, irfansharif (irfan sharif) wrote…
Can we make the Internal counter start at 2? The 100 was just an artifact from last release.
Done.
cd54ef1 to
20521e0
Compare
Release justification: Non-production code change. Release note: None
20521e0 to
3b3bec8
Compare
Collaborator
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #69828
Looking at past Version values for
Start{XX_X}, I think theVersionvalue forKey: Start22_1should instead beMajor: 21, Minor: 2, ....Start21_1 (from #70268):
Start 21_2:
Release justification: Non-production code change.
Release note: None