Skip to content

clusterversion: add a (disabled) assertion that binary version is latest#71625

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
dt:version-panic
Oct 18, 2021
Merged

clusterversion: add a (disabled) assertion that binary version is latest#71625
craig[bot] merged 1 commit intocockroachdb:masterfrom
dt:version-panic

Conversation

@dt
Copy link
Copy Markdown
Contributor

@dt dt commented Oct 15, 2021

This is intended to be flipped on and the release version updated when the cluster version mint
commit is backported to a release branch. Doing so would then prevent accidentally backporting
any future cluster versions without causing this to panic in all tests.

Release note: none.

This is intended to be flipped on and the release version updated when the cluster version mint
commit is backported to a release branch. Doing so would then prevent accidentally backporting
any future cluster versions without causing this to panic in all tests.

Release note: none.
@dt dt requested review from ajwerner and irfansharif October 15, 2021 21:40
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@dt
Copy link
Copy Markdown
Contributor Author

dt commented Oct 18, 2021

TFTR!

bors r+

craig bot pushed a commit that referenced this pull request Oct 18, 2021
71625: clusterversion: add a (disabled) assertion that binary version is latest r=dt a=dt

This is intended to be flipped on and the release version updated when the cluster version mint
commit is backported to a release branch. Doing so would then prevent accidentally backporting
any future cluster versions without causing this to panic in all tests.

Release note: none.

Co-authored-by: David Taylor <tinystatemachine@gmail.com>
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Oct 18, 2021

Build failed:

@dt
Copy link
Copy Markdown
Contributor Author

dt commented Oct 18, 2021

🥐

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Oct 18, 2021

Build succeeded:

@craig craig bot merged commit 38168db into cockroachdb:master Oct 18, 2021
@dt dt deleted the version-panic branch October 22, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants