server: fix TestAdminAPIJobs failure#70150
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 15, 2021
Merged
Conversation
This change sorts the expected job IDs before ensuring that they are equal. Fixes: cockroachdb#69401 Release note: None
Member
|
This change is |
Contributor
Author
|
I couldn't reproduce the failure, and it doesn't seem to have failed in a while. Eyeballing the error, the order is what seems mismatched, so adding this patch can only help. |
knz
approved these changes
Sep 14, 2021
Contributor
knz
left a comment
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained
Contributor
Author
|
dev-inf is investigating the shards timing out in bors r=knz |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
Contributor
|
Going to backport this to 21.2, to fix the test failing for #73624 |
Contributor
|
blathers backport 21.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change sorts the expected job IDs before ensuring
that they are equal.
Fixes: #69401
Release note: None