roachpb,sql.ui: remove Opt field from StatementStatisticsKey#69597
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 17, 2021
Merged
roachpb,sql.ui: remove Opt field from StatementStatisticsKey#69597craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
e79df89 to
96c5c29
Compare
Contributor
Author
|
Should we try to get this in for this release? Or we should wait for after the branch cut? |
Contributor
|
wait for after the branch cut |
matthewtodd
approved these changes
Sep 7, 2021
matthewtodd
left a comment
There was a problem hiding this comment.
Looks good to me! I love the smell of deleted code in the morning.
Reviewed 16 of 16 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @Azhng)
-- commits, line 2 at r1:
nit: It might be worth explicitly saying here why this field is safe to delete?
f6a96ad to
8ca1f86
Compare
This field is safe to delete because we have been filling this field with hard coded values since few releases ago. Resolves cockroachdb#68077 Release note: None Release justification:
8ca1f86 to
08b663b
Compare
Contributor
Author
|
TFTR! bors r=matthewtodd |
Contributor
|
Build failed: |
Contributor
Author
|
Hmm bors flaked, try again bors r=matthewtodd |
Contributor
|
Build succeeded: |
lindseyjin
pushed a commit
to lindseyjin/cockroach
that referenced
this pull request
Sep 17, 2021
69597: roachpb,sql.ui: remove Opt field from StatementStatisticsKey r=matthewtodd a=Azhng Resolves cockroachdb#68077 Release note: None 70364: docs: update readme for cluster-ui r=xinhaoz a=Azhng Previsouly, README in cluster-ui points to an incorrect directory to run yarn command. This commit update the directory mentioned in the README. Release note: None Co-authored-by: Azhng <archer.xn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #68077
Release note: None