server: make first node and store ID easy to change#69493
Merged
craig[bot] merged 3 commits intocockroachdb:masterfrom Aug 28, 2021
Merged
server: make first node and store ID easy to change#69493craig[bot] merged 3 commits intocockroachdb:masterfrom
craig[bot] merged 3 commits intocockroachdb:masterfrom
Conversation
Disable the internal timeseries write loop when starting cockroach purely to visualize a dump obtained via `./cockroach debug tsdump`. Release justification: low-impact debug-only fix Release note: None
The existing constant was previously not used in all places, meaning that changing FirstNodeID in one place would lead to a malfunctioning system. Release justification: low-risk change that is required for tsdump runbook Release note: None
Member
|
This change is |
Add a constant for the FirstStoreID. This allows one-off builds of CockroachDB that use a nonstandard first NodeID and StoreID, which is helpful for local metrics visualization (via the `tsdump` command). Release justification: low-risk change to unblock the tsdump runbook. Release note: None
619f281 to
12fb324
Compare
knz
approved these changes
Aug 28, 2021
Contributor
knz
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 4 of 4 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @erikgrinaker)
Member
Author
|
TFTR! bors r=knz |
Contributor
|
Build failed (retrying...): |
craig bot
pushed a commit
that referenced
this pull request
Aug 28, 2021
69478: kv: use txn deadline as MaxTimestampBound for bound staleness reads r=nvanbenschoten a=nvanbenschoten Fixes #69343. This commit updates Txn.NegotiateAndSend to respect any prior set transaction deadline. It does so by applying the deadline to the bounded staleness header's `MaxTimestampBound`. This is necessary to prevent the bounded staleness read from choosing a dynamic timestamp that is incoherent with the schema for the table being read. Release justification: fix to new functionality 69493: server: make first node and store ID easy to change r=knz a=tbg This is to enable the (sorry, internal) [runbook] to visualize a copy of the internal timeseries data of a cluster. While writing the runbook I found some sharp nails that this PR addresses. Mainly, the running node (n1) on top of which the timeseries data is imported used to clobber some data for n1. The interim solution is to start that server with a very high NodeID/StoreID (via a manual code change & build). This isn't the most user-friendly, but it's enough to unblock us and besides, the code changes here also constitute a desirable cleanup. [runbook]: https://cockroachlabs.atlassian.net/wiki/spaces/TS/pages/2168520776/Exporting+Internal+Timeseries+beta Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com> Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com>
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to enable the (sorry, internal) runbook to visualize a copy of the
internal timeseries data of a cluster. While writing the runbook I found some
sharp nails that this PR addresses. Mainly, the running node (n1) on top of
which the timeseries data is imported used to clobber some data for n1. The
interim solution is to start that server with a very high NodeID/StoreID (via
a manual code change & build). This isn't the most user-friendly, but it's
enough to unblock us and besides, the code changes here also constitute a
desirable cleanup.