Revert "streamingccl: hang processors on losing connection with sinkless stream client"#68918
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 16, 2021
Merged
Conversation
Member
arulajmani
approved these changes
Aug 13, 2021
ceac2e6 to
b123cc2
Compare
…ess stream client" This reverts commit f5244f4.
b123cc2 to
749c8ee
Compare
Contributor
Author
|
bors r=arulajmani |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
adityamaru
pushed a commit
to adityamaru/cockroach
that referenced
this pull request
Aug 24, 2021
In cockroachdb#68918 we reverted a change that taught stream ingestion processors to wait for a cutover on losing connection to the client. This was the first part of introducing the concept of generations to c2c streaming. The change was reverted due to a leaked goroutine during stress testing. This change does not alter any of the core logic but simply makes the test more reliable by adding a `Streaming` testing knob. This allows us to intercept when the stream ingestion processor receives an Event and perform the necessaery testing. Release justification: non-production code changes. Revert a revert of previously checked in logic by fixing the testing infrastructure that was leaking the goroutine.
craig bot
pushed a commit
that referenced
this pull request
Aug 29, 2021
69262: streamingccl: unrevert graceful cutover of stream ingestion r=pbardea a=adityamaru In #68918 we reverted a change that taught stream ingestion processors to wait for a cutover on losing connection to the client. This was the first part of introducing the concept of generations to c2c streaming. The change was reverted due to a leaked goroutine during stress testing. This change does not alter any of the core logic but simply makes the test more reliable by adding a `Streaming` testing knob. This allows us to intercept when the stream ingestion processor receives an Event and perform the necessary testing. Fixes: #68701 Fixes: #68795 Release justification (non-production code changes): Revert a revert of previously checked in logic by fixing the testing infrastructure that was leaking the goroutine. 69470: sql: Fix SHOW ZONE CONFIGURATIONS with very long constraints r=arulajmani a=ajstorm Previously, in the presence of very long constraints fields, SHOW ZONE CONFIGURATIONS would output the constraints with `\n` characters mixed in. This was due to the fact that the yaml.v2 library contained an 80 character line limit. We recently pulled in some commits to our fork of the yaml library which allows the line length to be configurable. With that change, we can now configure the line length to be unlimited in the case where we're showing the zone configuration, and get around the ugliness of the `\n` characters. Release note (sql change): Fixes a bug in SHOW ZONE CONFIGURATIONS where long constraints fields may show `\n` characters. Release justification: Low risk change to existing functionality. Co-authored-by: Anne Zhu <anne.zhu@cockroachlabs.com> Co-authored-by: Adam Storm <storm@cockroachlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit f5244f4.