I'll let @mrtracy have the final word on tsconfig since he's dealt with it the most.

Created a PR to address the fact that we keep including changes to the generated proto files #6843

This causes problems when writing tests in editors that check for errors. You won't get automatic errors while writing test files, because they will not be part of the compilation (because the tsconfig has no notion of them).

Review status: 0 of 21 files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

Are you sure? I'm still getting errors in my editor in test files.

It breaks both Vim and VSCode.

Review status: 0 of 21 files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

I believe an alternative fix is to ensure that the /// <reference> to typings is present in every file.

Yeah, that's true, but sucks :(
On May 23, 2016 19:19, "mrtracy" notifications@github.com wrote:

I believe an alternative fix is to ensure that the /// to
typings is present in every file.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#6839 (comment)

What's the status of this PR?

@tamird @mrtracy ?

We should sit down and talk about this since it's IDE specific. Some editors support the extra option filesGlob that might be useful here, but we should make sure it doesn't break anyone's workflow.

Apparently this is no longer an issue in vscode. I have also stopped using vim, so this shouldn't be an issue for our main contributors anymore.

I support getting this in, since bundling is broken for me locally.

LGTM

OK, will do in a bit.
On Jun 21, 2016 16:44, "Max Lang" notifications@github.com wrote:

I support getting this in, since bundling is broken for me locally.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#6839 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABdsPJSMQqvMbIdetqWvixwfCBnlUGL3ks5qOE0XgaJpZM4Ijw7Q
.