Skip to content

Ensures ui next builds and ui proto files are generated#6843

Merged
maxlang merged 1 commit intocockroachdb:masterfrom
maxlang:maxlang/ui-next-build-checks
May 23, 2016
Merged

Ensures ui next builds and ui proto files are generated#6843
maxlang merged 1 commit intocockroachdb:masterfrom
maxlang:maxlang/ui-next-build-checks

Conversation

@maxlang
Copy link
Copy Markdown
Contributor

@maxlang maxlang commented May 21, 2016

Ensures that the ui/next build succeeds.

Also, anyone who changes .proto files must generate the ts/js files used by the UI.

cc @tamird


This change is Reviewable

@maxlang maxlang changed the title Ensures ui next builds and ui proto files are genereated Ensures ui next builds and ui proto files are generated May 21, 2016
@maxlang maxlang force-pushed the maxlang/ui-next-build-checks branch from f0875f0 to 4523655 Compare May 21, 2016 16:11
@maxlang maxlang force-pushed the maxlang/ui-next-build-checks branch from 4523655 to c768538 Compare May 21, 2016 17:39
@tamird
Copy link
Copy Markdown
Contributor

tamird commented May 21, 2016

LGTM

1 similar comment
@mrtracy
Copy link
Copy Markdown
Contributor

mrtracy commented May 23, 2016

LGTM

@maxlang maxlang merged commit e4e06df into cockroachdb:master May 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants