Skip to content

release-21.1: sql: eagerly discard inbox/outbox memory#67609

Merged
yuzefovich merged 1 commit intorelease-21.1from
blathers/backport-release-21.1-67072
Jul 14, 2021
Merged

release-21.1: sql: eagerly discard inbox/outbox memory#67609
yuzefovich merged 1 commit intorelease-21.1from
blathers/backport-release-21.1-67072

Conversation

@blathers-crl
Copy link
Copy Markdown

@blathers-crl blathers-crl bot commented Jul 14, 2021 •
edited by yuzefovich
Loading

Backport 1/1 commits from #67072 on behalf of @jordanlewis.

/cc @cockroachdb/release

Release justification: low risk bug fix that should improve stability with many distributed flows.

Updates but doesn't close #67051

This commit adds some eager release of memory during batch serialization
and deserialization, in cases where scratch buffers aren't useful any
longer.

Release note (performance improvement): vectorized flows can use less
memory when sending and receiving data to the network.

@jordanlewis
sql: eagerly discard inbox/outbox memory
436d4ab 
This commit adds some eager release of memory during batch serialization
and deserialization, in cases where scratch buffers aren't useful any
longer.

Release note (performance improvement): vectorized flows can use less
memory when sending and receiving data to the network.
@blathers-crl blathers-crl bot requested a review from a team as a code owner July 14, 2021 15:47
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-21.1-67072 branch from 59c4e00 to 436d4ab Compare July 14, 2021 15:47
@blathers-crl blathers-crl bot requested a review from michae2 July 14, 2021 15:47
@blathers-crl
Copy link
Copy Markdown
Author

blathers-crl bot commented Jul 14, 2021

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Jul 14, 2021

This change is Reviewable

@yuzefovich
Copy link
Copy Markdown
Member

yuzefovich commented Jul 14, 2021

I think we should backport this change to 21.1 (as well as #67577), thoughts?

@yuzefovich yuzefovich merged commit 3727888 into release-21.1 Jul 14, 2021
@yuzefovich yuzefovich deleted the blathers/backport-release-21.1-67072 branch July 14, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michae2 michae2 michae2 approved these changes

Assignees

@jordanlewis jordanlewis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cockroach-teamcity @yuzefovich @michae2 @jordanlewis