Skip to content

sql: eagerly discard inbox/outbox memory#67072

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
jordanlewis:eager-mem-release
Jul 1, 2021
Merged

sql: eagerly discard inbox/outbox memory#67072
craig[bot] merged 1 commit intocockroachdb:masterfrom
jordanlewis:eager-mem-release

Conversation

@jordanlewis
Copy link
Copy Markdown
Member

Updates but doesn't close #67051

This commit adds some eager release of memory during batch serialization
and deserialization, in cases where scratch buffers aren't useful any
longer.

Release note (performance improvement): vectorized flows can use less
memory when sending and receiving data to the network.

@jordanlewis jordanlewis requested a review from a team June 30, 2021 14:26
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis)

This commit adds some eager release of memory during batch serialization
and deserialization, in cases where scratch buffers aren't useful any
longer.

Release note (performance improvement): vectorized flows can use less
memory when sending and receiving data to the network.
@jordanlewis
Copy link
Copy Markdown
Member Author

TFTR!

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 1, 2021

Build succeeded:

@craig craig bot merged commit f57cf6e into cockroachdb:master Jul 1, 2021
@jordanlewis jordanlewis deleted the eager-mem-release branch July 8, 2021 21:45
@yuzefovich
Copy link
Copy Markdown
Member

blathers backport 21.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sql: add memory accounting for temporary memory usage for serialization/deserialization in inbox and outbox

4 participants