Skip to content

roachtest: fix typeorm apt-get update#67548

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
RichardJCai:typeorm_roachtest_fix_07132021
Jul 14, 2021
Merged

roachtest: fix typeorm apt-get update#67548
craig[bot] merged 1 commit intocockroachdb:masterfrom
RichardJCai:typeorm_roachtest_fix_07132021

Conversation

@RichardJCai
Copy link
Copy Markdown
Contributor

Release note: None

@RichardJCai RichardJCai requested review from a team, rafiss and rail July 13, 2021 17:51
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Member

@rail rail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, :shipit:

@RichardJCai
Copy link
Copy Markdown
Contributor Author

Thanks!
bors r=rail

craig bot pushed a commit that referenced this pull request Jul 13, 2021
66560:  sql: allowing add missing tables from json file r=RichardJCai a=mnovelodou

 Previously, we could only add missing tables on information_schema or
 pg_catalog from dump json file
 This was inadequate because sometimes we need to manually decide how
 columns data types are going to be
 To address this, this patch adds a flag that allows to specify the json
 file where to find the missing tables

 Release note: None

67375: roachtest: ensure privileges stay consistent after version upgrades r=rafiss a=RichardJCai

roachtest: ensure privileges stay consistent after version upgrades

Release note: None

Resolves #65011

67548: roachtest: fix typeorm apt-get update r=rail a=RichardJCai

Release note: None

67550: authors: add xinhaoz to AUTHORS r=xinhaoz a=xinhaoz

Release note: None

67560: authors: add harding@cockroachlabs.com to authors. r=rharding6373 a=rharding6373

Release note: None

Co-authored-by: MiguelNovelo <miguel.novelo@digitalonus.com>
Co-authored-by: richardjcai <caioftherichard@gmail.com>
Co-authored-by: Xin Hao Zhang <xzhang@cockroachlabs.com>
Co-authored-by: rharding6373 <rharding6373@users.noreply.github.com>
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 13, 2021

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 13, 2021

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 14, 2021

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants