ccl/sqlproxyccl: skip TestDirectoryConnect#67406
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jul 9, 2021
Merged
ccl/sqlproxyccl: skip TestDirectoryConnect#67406craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Refs: cockroachdb#67405 Reason: flaky test Generated by bin/skip-test. Release justification: non-production code changes Release note: None
Member
|
This change is |
RichardJCai
approved these changes
Jul 9, 2021
Contributor
Author
|
bors r+ p=999 |
Contributor
|
Build succeeded: |
andy-kimball
added a commit
to andy-kimball/cockroach
that referenced
this pull request
Jul 10, 2021
- Fix flakiness of the TestDirectoryConnect test. - Fix minor deleteEntry race condition. - Consolidate EventType and PodState enumerations. - Do not add DRAINING pod addresses to directory. - Avoid locking to check tenantEntry initialization. Fixes cockroachdb#67406 Release note: None
andy-kimball
added a commit
to andy-kimball/cockroach
that referenced
this pull request
Jul 10, 2021
- Fix flakiness of the TestDirectoryConnect test. - Fix minor deleteEntry race condition. - Consolidate EventType and PodState enumerations. - Do not add DRAINING pod addresses to directory. - Avoid locking to check tenantEntry initialization. Fixes cockroachdb#67406 Release note: None
andy-kimball
added a commit
to andy-kimball/cockroach
that referenced
this pull request
Jul 10, 2021
- Fix flakiness of the TestDirectoryConnect test. - Fix minor deleteEntry race condition. - Consolidate EventType and PodState enumerations. - Do not add DRAINING pod addresses to directory. - Avoid locking to check tenantEntry initialization. Fixes cockroachdb#67406 Release note: None
craig bot
pushed a commit
that referenced
this pull request
Jul 10, 2021
67452: sqlproxy: fix flakiness and other small issues r=andy-kimball a=andy-kimball - Fix flakiness of the TestDirectoryConnect test. - Fix minor deleteEntry race condition. - Consolidate EventType and PodState enumerations. - Do not add DRAINING pod addresses to directory. - Avoid locking to check tenantEntry initialization. Fixes #67406 Release note: None Co-authored-by: Andrew Kimball <andyk@cockroachlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #67405
Reason: flaky test
Generated by bin/skip-test.
Release justification: non-production code changes
Release note: None