Skip to content

deps: update bufbuild/buf#67222

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
knz:20210705-buf2
Jul 5, 2021
Merged

deps: update bufbuild/buf#67222
craig[bot] merged 1 commit intocockroachdb:masterfrom
knz:20210705-buf2

Conversation

@knz
Copy link
Copy Markdown
Contributor

@knz knz commented Jul 5, 2021

Fixes #67216.

This is a simplified version of #67221 until a fix for the bazel rules (see this comment) is available.

Release note: None

Release note: None
@knz knz requested a review from dt July 5, 2021 17:05
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@knz
Copy link
Copy Markdown
Contributor Author

knz commented Jul 5, 2021

thanks!

bors r=dt

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 5, 2021

Build succeeded:

@craig craig bot merged commit 464ddb9 into cockroachdb:master Jul 5, 2021
@knz knz deleted the 20210705-buf2 branch July 5, 2021 19:25
@knz
Copy link
Copy Markdown
Contributor Author

knz commented Jul 6, 2021

The grpc upgrade incurred in this change is causing race tests to fail (#67248 #67237 ) so we'll want something else instead.

craig bot pushed a commit that referenced this pull request Jul 6, 2021
67256: Revert/redo "deps: update bufbuild/buf" r=tbg a=knz

Reverts and reimplements #67222  (the first time around I mistakenly upgraded to buf 0.43.1 instead of 0.42.1 as intended. The 0.43 version brings in a grpc upgrade which we don't want)

Fixes #67245
Fixes #67255
Fixes #67248 
Fixes #67246  
Fixes #67237 
Reverts  #67240 

Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build: cockroachdb build is broken on master

3 participants