storage: fix lease not actually renewed#65393
Closed
llllash wants to merge 1 commit intocockroachdb:masterfrom
llllash:store-lease-bug
Closed
storage: fix lease not actually renewed#65393llllash wants to merge 1 commit intocockroachdb:masterfrom llllash:store-lease-bug
llllash wants to merge 1 commit intocockroachdb:masterfrom
llllash:store-lease-bug
Conversation
Member
|
|
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. Before a member of our team reviews your PR, I have some potential action items for you:
I was unable to automatically find a reviewer. You can try CCing one of the following members:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Member
|
This change is |
a-robinson
reviewed
May 18, 2021
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
May 25, 2021
We were never looping around more than once as a result of never resetting the timer. This was noticed by contributor @llllash in cockroachdb#65393. Thank you! Closes cockroachdb#65393. Release note: None
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
May 31, 2021
We were never looping around more than once as a result of never resetting the timer. This was noticed by contributor @llllash in cockroachdb#65393. Thank you! Closes cockroachdb#65393. Co-authored-by: linyimin <linyimin@baidu.com> Release note: None
craig bot
pushed a commit
that referenced
this pull request
Jun 10, 2021
65653: kvserver: actually renew expiration-based leases r=nvanbenschoten a=tbg We were never looping around more than once as a result of never resetting the timer. This was noticed by contributor @llllash in #65393. Thank you! Closes #65393. It seems as though the mechanism to prevent ping-ponging of the r1 lease never quite worked, i.e. this issue wasn't actually closed: #24753 It's unclear why this hasn't caused more trouble over the last three years. However, looking at the original issue, it seems like you need very precise timing to get the problem to appear. Maybe that is a good enough explanation. Release note: None Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i found that the replica lease_holder did not actually renew in function startLeaseRenewer().
I can't believe it's been around for three years...
Is my fix right?
review it plz, thanks~ @a-robinson @tbg