cli/interactive_tests: complete the end-to-end test for cockroach connect#63846
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 20, 2021
Merged
cli/interactive_tests: complete the end-to-end test for cockroach connect#63846craig[bot] merged 1 commit intocockroachdb:masterfrom
cockroach connect#63846craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Contributor
Author
|
Current CI failure due to #63851 |
…nnect` The end-to-end test for the new `connect` command was incomplete, because of issue cockroachdb#61624 that was blocking the functionality. Now that cockroachdb#63589 is in, we can add the missing test. Release note: None
15bd009 to
26effee
Compare
itsbilal
approved these changes
Apr 20, 2021
Contributor
itsbilal
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @knz)
Contributor
Author
|
thank you! bors r=itsbilal |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The end-to-end test for the new
connectcommand was incomplete,because of issue #61624 that was blocking the functionality.
Now that #63589 is in, we can add the missing test.
Release note: None