-
Notifications
You must be signed in to change notification settings - Fork 4.1k
server: TestTelemetrySQLStatsIndependence failed #63851
Copy link
Copy link
Closed
Labels
C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.C-test-failureBroken test (automatically or manually discovered).Broken test (automatically or manually discovered).branch-masterFailures and bugs on the master branch.Failures and bugs on the master branch.
Description
Same symptom as #63844 on the master branch: there are leaked goroutines when the test ends.
This is not surprising because the test contains an unlimited call to ReportDiagnostics(). If the reg server is unavailable, that call blocks asynchronously and the goroutine leaks.
This should be fixed by making the test impervious to reg server failures, by using a temporary in-memory collector instead and customizing the TestingKnobs.OverrideReportingURL field.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.C-test-failureBroken test (automatically or manually discovered).Broken test (automatically or manually discovered).branch-masterFailures and bugs on the master branch.Failures and bugs on the master branch.