sql: add backup/restore tests for sequences#60957
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 23, 2021
the-ericwang35:ericwang/sequences_tests
Merged
sql: add backup/restore tests for sequences#60957craig[bot] merged 1 commit intocockroachdb:masterfrom the-ericwang35:ericwang/sequences_tests
craig[bot] merged 1 commit intocockroachdb:masterfrom
the-ericwang35:ericwang/sequences_tests
Conversation
Member
|
This change is |
Author
|
TFTR! bors r+ |
Contributor
|
Build failed (retrying...): |
Author
|
bors try |
Contributor
tryBuild failed: |
Author
|
bors r- |
Contributor
|
Canceled. |
This patch just adds tests for backup/restore with respect to sequences. Now that all new sequences are referenced by ID and can be renamed, we want to test that previously created sequences are not affected, and still follow the old rules (i.e. cannot be renamed and and are referenced by their names. In the future, we'll want to convert these old sequences to new sequences (i.e. can be renamed and are referenced by ID), but for now, we'll keep the old sequences as is. Release note (None): add backup/restore tests for sequences
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch just adds tests for backup/restore with respect to sequences.
Now that all new sequences are referenced by ID and can be renamed,
we want to test that previously created sequences are not affected,
and still follow the old rules (i.e. cannot be renamed and
and are referenced by their names.
Part of #51090.
In the future, we'll want to convert these old sequences to
new sequences (i.e. can be renamed and are referenced by ID,
see #60942) which means these tests will need to change, but
for now, we'll keep the old sequences as is.
Release note (None): add backup/restore tests for sequences