Implement and unittest EndTransaction.#60
Merged
spencerkimball merged 1 commit intomasterfrom Sep 15, 2014
Merged
Conversation
Added an implementation for EndTransaction which attempts to move a transaction from PENDING to either COMMITTED or ABORTED depending on the EndTransactionRequest.Commit argument. Various error conditions may result, including the txn already being committed or aborted, Epoch or timestamp regressions, or transaction retry on SSI txns in the event that the commit timestamp is different from the transaction timestamp.
Member
Author
Contributor
There was a problem hiding this comment.
meaning the other txn is aborted "or got pushed"
Member
Author
There was a problem hiding this comment.
In this case, where you have a write/write conflict, the only real success outcome (except that other transaction is already committed or aborted) is to abort the transaction. Only read/write conflicts are resolved by pushing the existing transaction's commit timestamp forward.
Contributor
|
LGTM |
spencerkimball
added a commit
that referenced
this pull request
Sep 15, 2014
Implement and unittest EndTransaction.
soniabhishek
pushed a commit
to soniabhishek/cockroach
that referenced
this pull request
Feb 15, 2017
…ng_empty_step empty step db migration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an implementation for EndTransaction which attempts to move a
transaction from PENDING to either COMMITTED or ABORTED depending on
the EndTransactionRequest.Commit argument. Various error conditions
may result, including the txn already being committed or aborted,
Epoch or timestamp regressions, or transaction retry on SSI txns
in the event that the commit timestamp is different from the transaction
timestamp.