Revert "Revert "util/log: more misc cleanups""#57222
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Nov 30, 2020
Merged
Revert "Revert "util/log: more misc cleanups""#57222craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
This re-instates cockroachdb#57000, as it did not "introduce a race in crdb" (Instead it merely outlined a bug in a test, which is to be fixed in a subsequent commit.) Release note: None
The pgwire code uses goroutines whose execution extends past the server's stopper's `Stop()` call. This is arguably a mis-design which needs to be fixed -- but in the meantime the logging package needs to tolerate it. This patch ensures that asynchronous `log` calls can be performed concurrently with a `TestLogScope`'s `Close()` call. Release note: None
Member
|
This change is |
itsbilal
approved these changes
Nov 30, 2020
Contributor
itsbilal
left a comment
There was a problem hiding this comment.
Reviewed 59 of 59 files at r1, 1 of 1 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @dt and @irfansharif)
irfansharif
approved these changes
Nov 30, 2020
Contributor
irfansharif
left a comment
There was a problem hiding this comment.
Woops, sorry about the misattribution, just friday evening laziness. LGTM (though I think we want to re-order these commits for git bisectability).
Contributor
Author
|
The two commits cannot be inverted - the 2nd commit works around the bug in the test within the context set up by the 1st commit. |
Contributor
Author
|
TFYR bors r=irfansharif |
Contributor
|
Build succeeded: |
knz
added a commit
to knz/cockroach
that referenced
this pull request
Dec 3, 2020
As discussed previously in cockroachdb#57222 - the SQL servers do not obey the server stop logic well and leak goroutines that continue to log while the TestLogScope gets closed. This commit continues to tolerate this misdesign by ensuring that some more stderr-related flags are accessed atomically. Release note: None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #57178.
This re-instates #57000, as it did not "introduce a race in crdb"
The description in #57178 was incorrect - instead #57161 / #57162 merely outlined a bug in some tests, which remains to be fixed.
This PR also includes a temporary workaround for said test bug.
Fixes #57162.
Fixes #57161 (presumably - although the symptoms there don't align).