Skip to content

util/log: misc fixes#56897

Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom
knz:20201119-log-cleanup
Nov 22, 2020
Merged

util/log: misc fixes#56897
craig[bot] merged 2 commits intocockroachdb:masterfrom
knz:20201119-log-cleanup

Conversation

@knz
Copy link
Copy Markdown
Contributor

@knz knz commented Nov 19, 2020 •
edited
Loading

This somehow slipped through the review of #56336
Helps towards #51987
Fixes #56936

@knz knz requested a review from itsbilal November 19, 2020 12:35
@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Nov 19, 2020

This change is Reviewable

itsbilal
itsbilal approved these changes Nov 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@itsbilal itsbilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@knz knz force-pushed the 20201119-log-cleanup branch 2 times, most recently from 7b5f684 to c7ddf79 Compare November 20, 2020 15:28
@knz knz changed the title util/log: remove a stray file util/log: misc fixes Nov 20, 2020
@knz knz mentioned this pull request Nov 20, 2020
Closed
@knz knz requested a review from a team as a code owner November 20, 2020 18:53
@knz
Copy link
Copy Markdown
Contributor Author

knz commented Nov 20, 2020 •
edited
Loading

@itsbilal would welcome your review on the additionals commits thx

@knz knz force-pushed the 20201119-log-cleanup branch 4 times, most recently from 4af9cd4 to 9f98c5d Compare November 22, 2020 12:04
@knz knz requested review from a team and adityamaru and removed request for a team November 22, 2020 12:04
@knz knz mentioned this pull request Nov 22, 2020
Merged
@knz
Copy link
Copy Markdown
Contributor Author

knz commented Nov 22, 2020

Nevermind - I opened a separate PR #57000 with the additional commits.
Will rewind and merge this.

@knz knz force-pushed the 20201119-log-cleanup branch from 9f98c5d to 7a25895 Compare November 22, 2020 12:07
@knz
Copy link
Copy Markdown
Contributor Author

knz commented Nov 22, 2020

bors r=itsbilal

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 22, 2020

Build failed:

@knz
Copy link
Copy Markdown
Contributor Author

knz commented Nov 22, 2020

bors r=itsbilal

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 22, 2020

Build failed:

@knz knz force-pushed the 20201119-log-cleanup branch from 7a25895 to 7c9f24b Compare November 22, 2020 20:34
@knz
Copy link
Copy Markdown
Contributor Author

knz commented Nov 22, 2020

bors r=itsbilal

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 22, 2020

Build succeeded:

@craig craig bot merged commit c8e6237 into cockroachdb:master Nov 22, 2020
@knz knz deleted the 20201119-log-cleanup branch November 23, 2020 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityamaru adityamaru Awaiting requested review from adityamaru

1 more reviewer

@itsbilal itsbilal itsbilal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

logs: log redaction broken

3 participants

@knz @cockroach-teamcity @itsbilal