-
Notifications
You must be signed in to change notification settings - Fork 4.1k
logs: log redaction broken #56936
Copy link
Copy link
Closed
Labels
C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Description
At master, 98fc9b3c760b56dcd4324ecb1da6aadb3d794f39, no matter how I set --redactable-logs, the log files contain unredactable messages. If I use --logtostderr, stderr gets redactable messages.
I think this broken @ #56336; before it seems to work.
Another thing I observed, both on master and before the patch above, is that the stderr logs are redactable no matter the value of --redactable-logs={true,false}. Is that expected?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.