schemachange/tenant: destroy tenant data with GC job#55756
Merged
craig[bot] merged 3 commits intocockroachdb:masterfrom Jan 16, 2021
Merged
schemachange/tenant: destroy tenant data with GC job#55756craig[bot] merged 3 commits intocockroachdb:masterfrom
craig[bot] merged 3 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
7683851 to
58e5197
Compare
58e5197 to
f7935b6
Compare
148fd06 to
c9fdf9b
Compare
pbardea
approved these changes
Oct 23, 2020
Contributor
pbardea
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 10 files at r2.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @dt, @lucy-zhang, and @pbardea)
c8e73a7 to
b4bceb5
Compare
spaskob
pushed a commit
to spaskob/cockroach
that referenced
this pull request
Oct 28, 2020
Informs cockroachdb#47904. This is a stop gap solution that will perform the operation synchronously inside the transaction that marks the tenant row as DROP and finally deletes the row. This PR is intended to be backported to 20.2 release branch. The long-term solution that implements cockroachdb#48775 is done in cockroachdb#55756 and will be our long term approach for release 21.0 and beyond. Release note: none.
spaskob
pushed a commit
to spaskob/cockroach
that referenced
this pull request
Oct 29, 2020
Informs cockroachdb#47904. This is a stop gap solution that will perform the operation synchronously inside the transaction that marks the tenant row as DROP and finally deletes the row. This PR is intended to be backported to 20.2 release branch. The long-term solution that implements cockroachdb#48775 is done in cockroachdb#55756 and will be our long term approach for release 21.0 and beyond. Release note: none.
craig bot
pushed a commit
that referenced
this pull request
Oct 29, 2020
55935: sql/tenant: synch clear range data on tenant drop request r=spaskob a=spaskob Informs #47904. This is a stop gap solution that will perform the operation synchronously inside the transaction that marks the tenant row as DROP and finally deletes the row. This PR is intended to be backported to 20.2 release branch. The long-term solution that implements #48775 is done in #55756 and will be our long term approach for release 21.0 and beyond. Release note: none. Co-authored-by: Spas Bojanov <spas@cockroachlabs.com>
0efe933 to
a5576c4
Compare
spaskob
pushed a commit
to spaskob/cockroach
that referenced
this pull request
Oct 29, 2020
Informs cockroachdb#47904. This is a stop gap solution that will perform the operation synchronously inside the transaction that marks the tenant row as DROP and finally deletes the row. This PR is intended to be backported to 20.2 release branch. The long-term solution that implements cockroachdb#48775 is done in cockroachdb#55756 and will be our long term approach for release 21.0 and beyond. Release note: none.
thoszhang
approved these changes
Nov 2, 2020
thoszhang
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 7 of 9 files at r4, 2 of 4 files at r5, 5 of 5 files at r6.
Reviewable status:
spaskob
pushed a commit
to spaskob/cockroach
that referenced
this pull request
Nov 6, 2020
Informs cockroachdb#47904. This is a stop gap solution that will perform the operation synchronously inside the transaction that marks the tenant row as DROP and finally deletes the row. This PR is intended to be backported to 20.2 release branch. The long-term solution that implements cockroachdb#48775 is done in cockroachdb#55756 and will be our long term approach for release 21.0 and beyond. Release note: none.
spaskob
pushed a commit
to spaskob/cockroach
that referenced
this pull request
Nov 9, 2020
Informs cockroachdb#47904. This is a stop gap solution that will perform the operation synchronously inside the transaction that marks the tenant row as DROP and finally deletes the row. This PR is intended to be backported to 20.2 release branch. The long-term solution that implements cockroachdb#48775 is done in cockroachdb#55756 and will be our long term approach for release 21.0 and beyond. Release note: none.
073f2e3 to
dcab263
Compare
added 3 commits
January 15, 2021 13:17
Informs cockroachdb#48775. This PR: - adds `DeleteTenantRecord` to remove a tenant record from the tenants table. - makes `GetTenantRecord` public. Release note: none.
Informs cockroachdb#48775. This PR adds tenant GC fields to schema change Details and Progress protos and adds support for deleting tenant's data via the schema change GC job. Release note: none.
This commit creates a GC tenant job in the end of the destroy tenant operation. Release note: none.
dcab263 to
161b3fb
Compare
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48775.
This PR adds tenant GC fields to schema change Details and
Progress protos and adds support for deleting tenant's data
via the schema change GC job.
Release note: none.