Revert "sql: fix inflated "overhead" in statement timings"#54124
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 9, 2020
Merged
Revert "sql: fix inflated "overhead" in statement timings"#54124craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This reverts commit 6371d37. This commit introduced a bug where service latencies could be negative. I believe this happens when the sessionEndParse phase time is not set. Reverting this commit until we have a proper fix. Fixes cockroachdb#45011 Fixes cockroachdb#54087 Release justification: release blocker fix Release note: None
Member
|
This change is |
RaduBerinde
approved these changes
Sep 9, 2020
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 6371d37.
This commit introduced a bug where service latencies could be negative.
I believe this happens when the sessionEndParse phase time is not set.
Reverting this commit until we have a proper fix.
Fixes #45011
Fixes #54087
Release justification: release blocker fix
Release note: None