Skip to content

sql: more EXPLAIN improvements#53003

Merged
craig[bot] merged 4 commits intocockroachdb:masterfrom
RaduBerinde:explain-improvements-2
Aug 19, 2020
Merged

sql: more EXPLAIN improvements#53003
craig[bot] merged 4 commits intocockroachdb:masterfrom
RaduBerinde:explain-improvements-2

Conversation

@RaduBerinde
Copy link
Copy Markdown
Member

sql: omit various EXPLAIN fields in non-verbose mode

This change removes some unnecessary fields, and relegates others to the VERBOSE
variant.

Release note (sql change): various improvements to EXPLAIN plans.

sql: improve EXPLAIN output for join nodes

This change folds the type of join (inner/outer/etc) into the node name itself
(e.g. hash join (left outer)). The "inner" type is omitted in non-verbose
mode.

Release note (sql change): various improvements to EXPLAIN plans.

sql: improve EXPLAIN output for scalar group by

Move "scalar" to the node name instead of a separate field.

Release note (sql change): various improvements to EXPLAIN plans.

sql: improve EXPLAIN output for set operations

Improve the node names for set operation: union/intersect/except [all].

Release note (sql change): various improvements in EXPLAIN plans.

@RaduBerinde RaduBerinde requested a review from a team as a code owner August 18, 2020 23:55
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

This change removes some unnecessary fields, and relegates others to the VERBOSE
variant.

Release note (sql change): various improvements to EXPLAIN plans.
This change folds the type of join (inner/outer/etc) into the node name itself
(e.g. `hash join (left outer)`). The "inner" type is omitted in non-verbose
mode.

Release note (sql change): various improvements to EXPLAIN plans.
Move "scalar" to the node name instead of a separate field.

Release note (sql change): various improvements to EXPLAIN plans.
Improve the node names for set operation: `union/intersect/except [all]`.

Release note (sql change): various improvements in EXPLAIN plans.
@RaduBerinde RaduBerinde force-pushed the explain-improvements-2 branch from 1f32454 to 266c711 Compare August 19, 2020 04:41
@RaduBerinde
Copy link
Copy Markdown
Member Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 19, 2020

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@RaduBerinde
Copy link
Copy Markdown
Member Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 19, 2020

Build succeeded:

@craig craig bot merged commit 935ae2e into cockroachdb:master Aug 19, 2020
nvb added a commit to nvb/cockroach that referenced this pull request Aug 20, 2020
Reverts a portion of cockroachdb#53003. These attributes are not included when they
are not interesting, but when they are included, they are very interesting
and deserve to be surfaced.
@RaduBerinde RaduBerinde deleted the explain-improvements-2 branch August 31, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants